This repository was archived by the owner on Oct 20, 2024. It is now read-only.
Bound estimated gas limit before relaying a bundle txn.#339
Open
wanliqun wants to merge 1 commit intostackup-wallet:mainfrom
Open
Bound estimated gas limit before relaying a bundle txn.#339wanliqun wants to merge 1 commit intostackup-wallet:mainfrom
wanliqun wants to merge 1 commit intostackup-wallet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should bound the estimated gas limit before relaying a bundle txn:
Estimated gas limit for a bundle transaction should be no less than the total gas limit, otherwise this transaction may be failed due to out of gas.
Also, bundler could lose money if estimated gas limit exceeds the sum of gas limits for all user operations.