feat: add block height to get-transaction RPC #6733
+54
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you call
/v3/transaction/:txid, you get the block's index block hash, but there still isn't an easy way to know if that block is canonical or not. Because this RPC was added for the purpose of indexers who are using this to determine the validity of a given transaction, it seems like adding this field to the response is the best option.There are two new fields:
Some(u64), if the tx is canonical, this is the height of the block it was inblock_height.is_some()