Fix wasm-issue-675 by adding feature flag for specific errors #6732
+20
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Acaccia-stacks
requested changes
Dec 2, 2025
Comment on lines
10849
to
10850
| .find("TypeError(CallableType(Trait(TraitIdentifier { name: ClarityName(\"foo\")") | ||
| .is_some()); |
Author
There was a problem hiding this comment.
Thank you for the review! Changed it to use contains instead of find.
Comment on lines
10919
to
10920
| .find("TypeError(CallableType(Trait(TraitIdentifier { name: ClarityName(\"foo\")") | ||
| .is_some()); |
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (28.69%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## feat/clarity-wasm-develop #6732 +/- ##
=============================================================
- Coverage 30.91% 28.69% -2.22%
=============================================================
Files 572 572
Lines 358768 358779 +11
=============================================================
- Hits 110903 102959 -7944
- Misses 247865 255820 +7955
... and 143 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Acaccia-stacks
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after #6726, since that PR addresses a sub-issue of the broader issue resolved here.
Fixes: stx-labs/clarity-wasm#675