Skip to content

Conversation

@mtodor
Copy link
Collaborator

@mtodor mtodor commented Dec 18, 2025

Description

This PR refactor tools tests.

  • I have added mocks for central services.
  • Changed to use these mocks in related tests.
  • Rename tools.go in vulnerability toolset to deployments.go because it contains fetching of deployments. And to match pattern for other tools.

Validation

  • Only CI tests and builds, because actual code is not changed

@mtodor mtodor requested a review from janisz as a code owner December 18, 2025 17:23
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

❌ Patch coverage is 0% with 108 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.36%. Comparing base (8000112) to head (1905801).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/toolsets/mock/api_server.go 0.00% 108 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   85.78%   77.36%   -8.43%     
==========================================
  Files          25       26       +1     
  Lines         964     1109     +145     
==========================================
+ Hits          827      858      +31     
- Misses        104      216     +112     
- Partials       33       35       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtodor mtodor force-pushed the mtodor/ROX-31479-add-fetching-of-images-for-deployments branch from dcd78bd to 7dffb8b Compare December 19, 2025 10:06
Base automatically changed from mtodor/ROX-31479-add-fetching-of-images-for-deployments to main December 19, 2025 10:24
@mtodor mtodor force-pushed the mtodor/refactor-tool-tests branch from e19b97b to 1905801 Compare December 19, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants