-
Notifications
You must be signed in to change notification settings - Fork 1
ROX-30257: implement permission change tracking #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Molter73
wants to merge
4
commits into
main
Choose a base branch
from
mauro/ROX-30257/track-mode-change
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+530
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e07d856 to
b96120b
Compare
b96120b to
1746a5f
Compare
d0e3b69 to
c2486b0
Compare
ovalenti
approved these changes
Dec 22, 2025
Contributor
ovalenti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems all good to me !
tests/test_path_chmod.py
Outdated
|
|
||
| e = Event(process=process, event_type=EventType.PERMISSION, | ||
| file=test_file, host_path=test_file, mode=mode) | ||
| print(f'Waiting foor event: {e}') |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo
3edf813 to
49ca519
Compare
ee54d95 to
aeee08e
Compare
This is done via the path_chmod LSM hook. WIP: the old mode is not quite working yet.
This allows us to exercise the trace_path_chmod bpf program on unit tests.
aeee08e to
ff2f6db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is done via the path_chmod LSM hook, extending the existing event structure to allow for additional, event type specific information to be sent to userspace.
Changes in userspace are relatively straightforward, the received event is translated into a new
ChmodFileDatatype that wraps the more genericBaseFileDataand adds fields specific for permission changes.Fromtraits are implemented for translation between this type and the gRPC protobuf messages.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
The existing bpf unit test has been extended with a permission change event in order to exercise the new bpf program.
Integration tests have been added for the new permission change events.