Renamed StateProperty to ObservableProperty and made the protocol public #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stackotter
requested changes
Nov 28, 2025
Owner
stackotter
left a comment
stackotter
left a comment
There was a problem hiding this comment.
Just requested a few small changes
| /// Declaring conformance to ObservableProperty is required for | ||
| /// SwiftCrossUI to automatically register an observer on the | ||
| /// conforming object's Publisher. | ||
| public protocol ObservableProperty { |
Owner
There was a problem hiding this comment.
Move this protocol its own file now that it's part of the public API.
Comment on lines
+132
to
+134
| /// Declaring conformance to ObservableProperty is required for | ||
| /// SwiftCrossUI to automatically register an observer on the | ||
| /// conforming object's Publisher. |
Owner
There was a problem hiding this comment.
Update to;
/// View properties that conform to ObservableProperty are automatically observed by SwiftCrossUI.
///
/// This protocol is intended to be implemented by property wrappers. You shouldn't
/// have to implement it for your own model types.
| /// Declaring conformance to ObservableProperty is required for | ||
| /// SwiftCrossUI to automatically register an observer on the | ||
| /// conforming object's Publisher. | ||
| public protocol ObservableProperty { |
Owner
There was a problem hiding this comment.
I think that ObservableProperty should inherit from DynamicProperty, because it doesn't make sense to implement an ObservableProperty whose state doesn't persist across view recalculations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, I changed the protocol to be publicly available, allowing for more third party view update triggering property wrappers, i.e. @query or @AppStorage
Also I renamed it do ObservableProperty, decoupling it verbally from @State.
Doing this involved declaring the protocol-required properties and functions as public too and replacing StateProperty with ObservableProperty wherever it gets used.
0 sideeffects expected, as there were no logic changes, aside from making some functions/values more accessible.