Populate remote workload metadata in GetWorkload #2929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote workloads returned incomplete data when queried, missing URL, port, transport type, group, and labels. This caused clients to fail when trying to connect since they need the local proxy URL to reach the remote server. Load the run config to populate these missing fields. The URL generated is the local proxy URL (not the remote server URL) so clients connect through ToolHive's proxy layer. Signed-off-by: carlos <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
==========================================
- Coverage 56.39% 56.30% -0.10%
==========================================
Files 322 323 +1
Lines 31622 31799 +177
==========================================
+ Hits 17834 17904 +70
- Misses 12257 12366 +109
+ Partials 1531 1529 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2035
Remote workloads returned incomplete data when queried, missing URL, port, transport type, group, and labels. This caused clients to fail when trying to connect since they need the local proxy URL to reach the remote server.
Load the run config to populate these missing fields. The URL generated is the local proxy URL (not the remote server URL) so clients connect through ToolHive's proxy layer.