Open
Conversation
Cyber28
requested changes
Aug 28, 2023
| obj/ No newline at end of file | ||
| obj/ | ||
| .vs/ | ||
| Icon Sources/ |
Collaborator
There was a problem hiding this comment.
This feels like a personal thing, not something that should be in the template
Author
There was a problem hiding this comment.
The .vs/ thing kills me every time. I had to fork the mod-template. :)
| # check dll has unique name | ||
| if DLL_NAME.lower() == "examplemod.dll": | ||
| print("Did you forget to rename the DLL in the project settings?") | ||
| exit(1); |
Collaborator
There was a problem hiding this comment.
I think a warning is enough here, maybe link to https://modding.stacklands.co/en/latest/guides/tutorial.html#step-1-setting-up-the-template as well
Author
There was a problem hiding this comment.
This is why pull requests aren't requests. Not demands. At least put something there.
| @@ -0,0 +1 @@ | |||
| Term Notes English No newline at end of file | |||
Collaborator
There was a problem hiding this comment.
Not sure if including a localization file is a good choice
- People going through the tutorial could be confused by it, as the tutorial tells them to download a completely different file
- I assume most people would use a tool like Google Sheets to edit their localization files instead of a code/text editor
- Even if the above assumption is incorrect, it's easy enough to create manually thanks to the localization guide
Author
There was a problem hiding this comment.
I'm old school. I edit the file in visual studio directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The important change is the in the build.py file. Including an empty localization.tsv can't hurt. In .gitignore, .vs/ is very important. The other changes, less so.