-
Couldn't load subscription status.
- Fork 23
fix(docs): correct playbook commands and minor inconsistencies in Ubuntu Noble upgrade guide #1927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2025.1
Are you sure you want to change the base?
Conversation
…ntu Noble upgrade guide - Fix incorrect ceph-enter-maintenance.yml usage where ceph-exit-maintenance.yml should be used - Add missing -e flags to pulp-repo-publish.yml and pulp-repo-promote-production.yml commands - Fix typo: "change" -> "chance" in storage section potential issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides important corrections to the Ubuntu Noble upgrade documentation. The changes correctly add missing flags to playbook commands, fix incorrect playbook usage for Ceph maintenance operations, and correct a typo. These fixes significantly improve the accuracy and reliability of the upgrade guide. I've added a couple of suggestions to improve the readability of the long shell commands by splitting them across multiple lines.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
lgtm but unfortunately our CI won't run correctly on repo forks. I'd be in favor of force-merging this though as it's such a simple docs change. @mnasiadka or @priteau are required for that |
| kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-sync.yml \ | ||
| -e stackhpc_pulp_sync_ubuntu_jammy=true \ | ||
| -e stackhpc_pulp_sync_ubuntu_noble=true | ||
| kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-publish.yml \ | ||
| -e stackhpc_pulp_sync_ubuntu_jammy=true \ | ||
| -e stackhpc_pulp_sync_ubuntu_noble=true | ||
| Once the host package content has been tested in a test/staging environment, it | ||
| may be promoted to production: | ||
|
|
||
| .. code-block:: console | ||
| kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-promote-production.yml | ||
| kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-promote-production.yml \ | ||
| -e stackhpc_pulp_sync_ubuntu_jammy=true \ | ||
| -e stackhpc_pulp_sync_ubuntu_noble=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stackhpc_pulp_sync_ubuntu_jammy variable is gone from this branch.
|
@jasonrayne Thank you for these fixes! I am just confused by why you need to set
Can you double check your configuration settings? |
|
And on 2024.1 the variable is set as: |
|
@priteau I think the problem is if you are on Ubuntu Jammy and 2024.1 you it won't sync Noble packages as observed during the upgrade process. https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/2024.1/etc/kayobe/pulp.yml#L70 |
|
@priteau Jack is correct. My KC is synced with SKC |
-eflags topulp-repo-publish.ymlandpulp-repo-promote-production.ymlplaybook commands (without these flags, Noble repos are not promoted, causing apt failures on upgraded systems)ceph-enter-maintenance.ymlusage whereceph-exit-maintenance.ymlshould be used when taking hosts out of maintenance mode