Skip to content

Conversation

@jasonrayne
Copy link
Contributor

  • Add missing -e flags to pulp-repo-publish.yml and pulp-repo-promote-production.yml playbook commands (without these flags, Noble repos are not promoted, causing apt failures on upgraded systems)
  • Fix incorrect ceph-enter-maintenance.yml usage where ceph-exit-maintenance.yml should be used when taking hosts out of maintenance mode
  • Fix typo: "change" -> "chance" in storage section potential issues

…ntu Noble upgrade guide

- Fix incorrect ceph-enter-maintenance.yml usage where
ceph-exit-maintenance.yml should be used
- Add missing -e flags to pulp-repo-publish.yml and
pulp-repo-promote-production.yml commands
- Fix typo: "change" -> "chance" in storage section potential issues
@jasonrayne jasonrayne requested a review from a team as a code owner October 9, 2025 20:07
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request provides important corrections to the Ubuntu Noble upgrade documentation. The changes correctly add missing flags to playbook commands, fix incorrect playbook usage for Ceph maintenance operations, and correct a typo. These fixes significantly improve the accuracy and reliability of the upgrade guide. I've added a couple of suggestions to improve the readability of the long shell commands by splitting them across multiple lines.

jasonrayne and others added 2 commits October 9, 2025 13:12
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@Alex-Welsh
Copy link
Member

lgtm but unfortunately our CI won't run correctly on repo forks. I'd be in favor of force-merging this though as it's such a simple docs change.

@mnasiadka or @priteau are required for that

@Alex-Welsh Alex-Welsh enabled auto-merge (squash) October 10, 2025 13:21
Comment on lines +82 to +96
kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-sync.yml \
-e stackhpc_pulp_sync_ubuntu_jammy=true \
-e stackhpc_pulp_sync_ubuntu_noble=true
kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-publish.yml \
-e stackhpc_pulp_sync_ubuntu_jammy=true \
-e stackhpc_pulp_sync_ubuntu_noble=true
Once the host package content has been tested in a test/staging environment, it
may be promoted to production:

.. code-block:: console
kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-promote-production.yml
kayobe playbook run $KAYOBE_CONFIG_PATH/ansible/pulp-repo-promote-production.yml \
-e stackhpc_pulp_sync_ubuntu_jammy=true \
-e stackhpc_pulp_sync_ubuntu_noble=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stackhpc_pulp_sync_ubuntu_jammy variable is gone from this branch.

@priteau
Copy link
Member

priteau commented Oct 21, 2025

@jasonrayne Thank you for these fixes! I am just confused by why you need to set stackhpc_pulp_sync_ubuntu_noble at all, since it should be true:

stackhpc_pulp_sync_ubuntu_noble: "{{ os_distribution == 'ubuntu' }}"

Can you double check your configuration settings?

@priteau
Copy link
Member

priteau commented Oct 21, 2025

And on 2024.1 the variable is set as: stackhpc_pulp_sync_ubuntu_noble: "{{ os_release == 'noble' }}"

@jackhodgkiss
Copy link
Contributor

@priteau I think the problem is if you are on Ubuntu Jammy and 2024.1 you it won't sync Noble packages as observed during the upgrade process.

https://github.com/stackhpc/stackhpc-kayobe-config/blob/stackhpc/2024.1/etc/kayobe/pulp.yml#L70

@jasonrayne
Copy link
Contributor Author

@priteau Jack is correct. My KC is synced with SKC stackhpc/2024.1, and I was not planning to fully switch to 2025.1 until after the Noble upgrades were complete. So my pulp.yml still has stackhpc_pulp_sync_ubuntu_noble: "{{ os_release == 'noble' }}" rather than stackhpc_pulp_sync_ubuntu_noble: "{{ os_distribution == 'ubuntu' }}".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants