Add option to install nvidia-fabricmanager #836
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudia-lola
force-pushed
the
fabricmanager
branch
from
3e9ab24 to
de76ee4
Compare
sjpb
requested changes
Oct 24, 2025
There was a problem hiding this comment.
Once changes are done, could you manually trigger an extra build on this branch please, AND add a comment linking to the workflow run?
Then we'll merge once that build passes/comments are addressed.
Remove commented option for installing nvidia-fabricmanager.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the CUDA Ansible role defaults to improve flexibility and control over package installation, particularly for the NVIDIA Fabric Manager. The main changes introduce a new option to conditionally install the Fabric Manager and refactor how package lists are constructed.
Improvements to package management:
cuda_install_nvidiafabricmangerto control whether the NVIDIA Fabric Manager is installed, defaulting tofalse.cuda_packages_defaultandcuda_packages_fabricmanager, and refactoredcuda_packagesto dynamically include the Fabric Manager package based on the new option.Versioning and configuration updates:
cuda_nvidia_driver_versionvariable for clearer driver version management and updatedcuda_nvidia_driver_pkgto use it.cuda_packages_fabricmanagerto specify the Fabric Manager package version using the new driver version variable.