Backport support for Tenks network persistence

[MaxBed4d]

This is a backport of this PR#200 due to the latest deployable version of the AUFN labs being for 2024.1

[gemini-code-assist]

Summary of Changes

Hello @MaxBed4d, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports critical support for Tenks network persistence to the 2024.1 deployable version of AUFN labs. The changes ensure that network configurations are reliably maintained across system reboots, enhancing the stability and consistency of the lab environments by automating the network setup process at startup.

Highlights

• Systemd Service for Network Persistence: A new systemd service, tenks-network-on-boot.service, has been introduced to ensure that Tenks network configurations are automatically applied upon system startup, providing persistence across reboots.
• Tenks Network Setup Script: A new bash script, tenks-network-setup, has been added. This script is executed by the systemd service and handles the activation of the Kayobe virtual environment, sourcing of necessary environment variables, and execution of the tenks-network-reboot-patch.sh to configure Tenks networking.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request backports support for Tenks network persistence by adding a systemd service and a setup script. My review has identified a critical bug in the setup script that will cause it to fail, a high-severity issue with the script's path in the service definition, and a medium-severity concern regarding user and group permissions in the service file. Please see the detailed comments for suggestions on how to address these issues.

[gemini-code-assist]

The awk command used to find environment variables to unset is incorrect. It will not correctly extract the variable names because FS is set inside the action block, which is too late for field splitting. This will cause the unset command to fail with a syntax error if any OS_* variables are set, as it will attempt to run unset "VAR=value".

A more robust and idiomatic way to unset all variables with a certain prefix in bash is to use parameter expansion.

Suggested change

	for key in $( set | awk '{FS="="} /^OS_/ {print $1}' ); do unset $key ; done
	for var in "${!OS_@}"; do unset "$var"; done

[gemini-code-assist]

The ExecStart path is /bin/tenks-network-setup, but this script is added at the repository root. Without a visible installation step to move it to /bin, the service will likely fail to start. Please verify the script's installation path and update ExecStart accordingly. If it's meant to be in the WorkingDirectory, the path should be tenks-network-setup.

[gemini-code-assist]

Setting Group=root for a service running as a non-root user (User=lab) is unusual and a potential security concern. This requires the lab user to be a member of the root group, which is generally discouraged. If elevated privileges are needed, consider alternative approaches like using sudo within the script for specific commands, or running the service as root if the entire script requires it.