feat: respect core.commentChar setting for escaping comment characters in commit messages #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NonLogicalDev
force-pushed
the
cli@w2jel
branch
3 times, most recently
from
1ccbeac to
819bccb
Compare
…s in commit messages Bring StGit in parity with git's behavior for comment characters. Setting `core.commentChar` to a value other than '#' allows the use of certain markup like markdown in commit messages. Git for that reason allows overriding the comment character to any string value. This change incurs a small amount of extra allocations for constructing strings at runtime taking into account the user's choice of comment character. issue: 600
NonLogicalDev
force-pushed
the
cli@w2jel
branch
from
819bccb to
8204a1d
Compare
jpgrayson
approved these changes
Nov 28, 2025
Collaborator
jpgrayson
left a comment
jpgrayson
left a comment
There was a problem hiding this comment.
Love this. Thank you. I've rebased and pushed this change to master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring StGit in parity with git's behavior for comment characters. Setting
core.commentCharto a value other than '#' allows the use of certain markup like markdown in commit messages. Git for that reason allows overriding the comment character to any string value.This change incurs a small amount of extra allocations for constructing strings at runtime taking into account the user's choice of comment character.
issue: #600