feat: Allow adding entries to the OpenSearch keystore #76
+385
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labrenbe
force-pushed
the
feat/snapshot-s3
branch
from
753e529 to
c77ac69
Compare
labrenbe
moved this from Development: In Progress
to Development: Waiting for Review
in Stackable Engineering
siegfriedweber
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
siegfriedweber
requested changes
Dec 4, 2025
| :description: Add entries to the OpenSearch Keystore | ||
|
|
||
| The OpenSearch keystore provides secure storage for sensitive configuration settings such as credentials and API keys. | ||
| You can populate the keystore by referencing Secrets from in your OpenSearch configuration. |
Member
There was a problem hiding this comment.
Suggested change
| You can populate the keystore by referencing Secrets from in your OpenSearch configuration. | |
| You can populate the keystore by referencing Secrets within your OpenSearch configuration. |
| ] | ||
| .into(), | ||
| vec. |
Member
There was a problem hiding this comment.
nit:
Suggested change
| pub keystore: Vec<OpenSearchKeystore>, | |
| /// Name of the Vector aggregator [discovery ConfigMap](DOCS_BASE_URL_PLACEHOLDER/concepts/service_discovery). | |
| pub keystore: Vec<OpenSearchKeystore>, | |
| /// Name of the Vector aggregator [discovery ConfigMap](DOCS_BASE_URL_PLACEHOLDER/concepts/service_discovery). |
| crd::{ | ||
| NodeRoles, | ||
| v1alpha1::{self}, | ||
| v1alpha1::{self, OpenSearchKeystore, SecretKeyRef}, |
Member
There was a problem hiding this comment.
Suggested change
| v1alpha1::{self, OpenSearchKeystore, SecretKeyRef}, | |
| v1alpha1::{self}, |
Comment on lines
+80
to
+83
| crd::{ | ||
| NodeRoles, | ||
| v1alpha1::{self, OpenSearchKeystore, SecretKeyRef}, | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| crd::{ | |
| NodeRoles, | |
| v1alpha1::{self, OpenSearchKeystore, SecretKeyRef}, | |
| }, | |
| crd::{NodeRoles, v1alpha1}, |
Comment on lines
+757
to
+760
| crd::{ | ||
| NodeRoles, | ||
| v1alpha1::{self, OpenSearchKeystore, SecretKeyRef}, | ||
| }, |
Member
There was a problem hiding this comment.
Suggested change
| crd::{ | |
| NodeRoles, | |
| v1alpha1::{self, OpenSearchKeystore, SecretKeyRef}, | |
| }, | |
| crd::{NodeRoles, v1alpha1}, |
| - key: s3.client.default.access_key | ||
| secretKeyRef: | ||
| name: s3-credentials | ||
| key: s3.client.default.access_key |
Member
There was a problem hiding this comment.
nit: The keys in the Secret could be renamed to ACCESS_KEY and SECRET_KEY. If a test uses the same value for different fields (keystore.key and keystore.secretKeyRef.key in this case), the code could read the wrong field and the test would still be successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow referencing Secret keys in the OpenSearch config to add them as entries to the OpenSearch keystore.
Part of #44.
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker