chore: ensure metrics are correctly exposed #701
+209
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 15, 2025
Techassi
reviewed
Oct 17, 2025
Techassi
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Co-authored-by: Techassi <[email protected]>
Co-authored-by: Techassi <[email protected]>
Co-authored-by: Techassi <[email protected]>
Techassi
reviewed
Oct 29, 2025
Comment on lines
+760
to
+767
| /// Name of the port used by the Web UI, which depends on HTTPS usage | ||
| pub fn ui_port_name(hbase: &v1alpha1::HbaseCluster) -> &str { | ||
| if hbase.has_https_enabled() { | ||
| HBASE_UI_PORT_NAME_HTTPS | ||
| } else { | ||
| HBASE_UI_PORT_NAME_HTTP | ||
| } | ||
| } |
There was a problem hiding this comment.
note: This feels weird being implemented on HbaseRole, as the role is not needed at all here (just the HbaseClsuter). Therefore it makes sense to move it back to where it was before.
There was a problem hiding this comment.
It is static, i see your point but rather have it at one point in the code (i could move it out of the role though - and maybe use a boolean instead of the cluster....)?
Co-authored-by: Techassi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of stackabletech/issues#747
This PR adds a metrics service with the additional Prometheus annotations. It also adds some documentation on monitoring for the TLS case since, similar to NiFi, HBase also exposes metrics behind a port which gets secured by TLS
Follow up monitoring Stack PR because moving to the metrics service, the port name changed: stackabletech/demos#316
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker