Skip to content

Conversation

@xeniape
Copy link
Member

@xeniape xeniape commented Oct 13, 2025

Description

Part of stackabletech/issues#747
This PR adds Prometheus annotations and adds a pod port for metrics

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@xeniape xeniape self-assigned this Oct 13, 2025
@xeniape xeniape moved this to Development: Waiting for Review in Stackable Engineering Oct 13, 2025
@adwk67 adwk67 self-requested a review October 13, 2025 14:18
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 13, 2025
adwk67
adwk67 previously approved these changes Oct 13, 2025
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xeniape
Copy link
Member Author

xeniape commented Oct 15, 2025

LGTM: image

Nit: In the Hive PR Malte replaced these with callouts from operator-rs: https://github.com/stackabletech/druid-operator/pull/761/files#diff-8df1bae7fe400b1c62e55f2dca18cd143b8a7994f7d8fe5a41fd7954f4627aaaR112-R119

Yep thank you! Sorry, took a while, wanted to finish the hbase PR first :) d6fb58d

@xeniape xeniape requested a review from adwk67 October 15, 2025 12:24
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xeniape xeniape added this pull request to the merge queue Oct 15, 2025
Merged via the queue into main with commit cbbe19e Oct 15, 2025
17 checks passed
@xeniape xeniape deleted the chore/ensure-metrics-correctly-exposed branch October 15, 2025 14:54
@xeniape xeniape moved this from Development: In Review to Development: Done in Stackable Engineering Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants