Do not include whitespace when applying inline markdown styles#14
Open
Rosey wants to merge 22 commits intosstur:masterfrom
Open
Do not include whitespace when applying inline markdown styles#14Rosey wants to merge 22 commits intosstur:masterfrom
Rosey wants to merge 22 commits intosstur:masterfrom
Conversation
Support headers 4, 5 and 6
Requires Image enum value from `draft-js-utils`.
Support image export based on entity attributes
Fixed support for image type entity
per package.json and the contents of the LICENSE file
If you test out markdown on a gist, markdown like this: ```markdown **Test ** ``` (with trailing or leading whitespace) is not properly parsed. This change only surrounds the text with markdown inline styles and preserves the whitespace, but doesn't attempt to style it, fixing the issue of incompatibility with markdown parsers.
Rosey
force-pushed
the
do_not_wrap_whitespace
branch
from
e2d54c6 to
54ffc22
Compare
sstur
force-pushed
the
master
branch
2 times, most recently
from
255f0a8 to
f6c1e51
Compare
|
@Rosey are you planning to fix the conflicts? Your PR most probably also solved sstur/react-rte#127 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you test out markdown on a gist, markdown like this:
(with trailing or leading whitespace) is not properly parsed. (examples here: https://gist.github.com/Rosey/3f848d77b46f7ab337a53211117acd87)
This change only surrounds the text with markdown inline styles and preserves
the whitespace, but doesn't attempt to style it, fixing the issue of
incompatibility with markdown parsers.
I'm not super confident about the efficiency of my regular expression here. It works, but I am worried that it is not optimal. Perhaps someone with better regex-fu will know if it can be improved performance-wise.