π Fix Unsafe Output of Untrusted Input in Bash Hook#7
Conversation
Co-authored-by: sstklen <90471971+sstklen@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π― What: Fixed an issue in
β οΈ Risk: If the
hooks/pre-bash-guard.shwhereecho "$CMD"was used.$CMDinput began with-nor-e,echomight interpret it as a flag instead of printing it, potentially bypassing the guard for dangerous commands or causing unintended side effects.π‘οΈ Solution: Replaced
echo "$CMD"withprintf '%s\n' "$CMD", ensuring the variable is safely output without any interpretation as a command line flag.PR created automatically by Jules for task 10905106132030780785 started by @sstklen