-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: add positional argument support to slash commands #3456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Rienkim I think we are gonna do named args instead of that format, if you are up for it if you update this pr to support named args I will review and merge it |
cf420ad to
1727741
Compare
|
@rekram1-node In the custom command prompt, ARGUMENTS is applied as follows: |
|
@Rienkim actually I talked with the team let's just do a similar thing to what claude code does, we can use the $1, $2 for positional args like sql, and otherwise everything is replaced into $ARGUMENTS See their docs for inspiration: https://docs.claude.com/en/docs/claude-code/slash-commands#arguments |
|
@rekram1-node |
|
sweet thanks! |
1727741 to
4aa9e91
Compare
|
@rekram1-node |
|
Nice work! Gonna make some tweaks and merge |
- manual for $1, $2 argument
4aa9e91 to
6fd94a2
Compare
$ARGUMENTSindexing and splitting for/commands#2199 had a merge conflict that was not resolved, so I am submitting a new PR with the merge conflict resolved.$ARGUMENTS[n+],$ARGUMENTS[n++]becasue they can be replaced by$ARGUMENTS[n:n+1],$ARGUMENTS[n:n+2].$ARGUMENTSas before.Closes #2199