fix(mesh): avoid NAT between allowed location IPs - #521
Open
JSap0914 wants to merge 1 commit into
Open
Conversation
Add source-and-destination RETURN rules for allowed location CIDRs in the local segment so traffic between disjoint site networks does not fall through to MASQUERADE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
KILO-NATreturn rules for traffic between allowed location CIDRs in the local segmentWhy
Traffic between two
allowedLocationIPsCIDRs in the same location currently entersKILO-NATand falls through toMASQUERADE. Returning before the final NAT rule preserves the original source address for traffic that remains within the site.Fixes #496
Tests
docker run --rm -v "$PWD:/src" -w /src golang:1.25.0 go test -mod=vendor ./pkg/mesh -run ^'TestRulesDoNotNATBetweenAllowedLocationIPs$' -count=1docker run --rm -v "$PWD:/src" -w /src golang:1.25.0 go test -mod=vendor ./pkg/mesh -count=1docker run --rm -v "$PWD:/src" -w /src golang:1.25.0 go test -mod=vendor -race ./...docker run --rm -v "$PWD:/src" -w /src golang:1.25.0 go vet -mod=vendor ./...docker run --rm -v "$PWD:/src" -w /src golangci/golangci-lint:v2.12.2 golangci-lint run --modules-download-mode=vendor ./...