Fix initial bool value to avoid sending update to kubelet every 5 seconds - #81
Merged
Conversation
Contributor
Author
|
Hey @squat Thanks |
squat
approved these changes
Jul 10, 2025
duckfullstop
approved these changes
Jul 10, 2025
duckfullstop
left a comment
Contributor
There was a problem hiding this comment.
No idea why Github included me on this PR, but have a LGTM from me regardless 👍
Owner
|
Hehehe sorry @duckfullstop I accidentally mentioned you rather than the author. Thank you for your service |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ListAndWatch()uses return value ofrefreshDevices()to make a decision regarding sending the updated devices to kubelet.Boolean default value is false, therefore variable
equalis always false andrefreshDevices()always returns false. This causesListAndWatch()to always send updates to kubelets which causes flood of logs: