Allow watch faces to implement custom handleButtonPress functions#165
Closed
synthead wants to merge 1 commit intosqfmi:masterfrom
Closed
Allow watch faces to implement custom handleButtonPress functions#165synthead wants to merge 1 commit intosqfmi:masterfrom
synthead wants to merge 1 commit intosqfmi:masterfrom
Conversation
86a95c0 to
6af6742
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows users to implement custom implementations for
handleButtonPress!For example, with the changes in this PR, I could do:
This example gives a "tactile" effect for every button press by doing two things:
handleButtonPressfrom the Watchy libraryThese changes are backward-compatible: if a watch face does not implement
handleButtonPress, then there will be no functional changes with any watch face.In addition, calling
Watchy::handleButtonPress()from the user's ownhandleButtonPressfunction will make the watch perform its regular functions with the original buttons. However, if the user would like to have their own menu, for example, they don't need to always callWatchy::handleButtonPress(). This could look like this:Other examples of how this could be implemented: