Open
Conversation
`libipld` is deprecated, hence remove its usage. Instead use `serde_ipld_dagcbor` and `cid`. Closed spruceid#620.
|
|
Contributor
|
hehe i vouch for this weirdo. @chunningham nota bene on the kepler side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
libipldis deprecated, hence remove its usage. Instead useserde_ipld_dagcborandcid.Closes #620.
Other changes
This commit also removes the
to_block()andfrom_block()functions. They are part of the public interface, so this is a breaking change. To me it's unclear what are used for. The only occurrence I found on GitHub was in the Kepler code base, but that project was archived already a year ago. Hence I decided to remove that functionality. It case it's still needed, I'm happy to add it back in case some more information is provided on how that API should be used.Tested
I ran
cargo testwithin thessi-ucancrate.