You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Adds a CheckableSchema enum, similar to the CheckableStatus enum in ssi-vc that (for now) only supports 1EdTechJSONSchemaValidator2019 schemas, though boon supports much more
Adds a test CLR Credential and uses it to add a credential_schema test that makes sure everything is working!
I chose a CLR because that is what I'm working towards trying to implement full support for!
Adds OBv3.0.1, OBv3 Extensions, and CLRv2 contexts (these were needed for the above test credential)
For some reason, rustc likes to sometimes error at me about the iri_match macro, complaining that a comma is missing. I have found that adding a comma like so fixes that:
Feel free to remove that comma if necessary, I'm not really sure why it's happening to me as Rust macros still make my brain stop working a bit!
One more bit of reference: These are my cargo/rustc versions I am using and seeing that error with:
ssi is currently in the middle of a major refactor, so we will hold off adding such new feature until it's complete.
A couple of thoughts though after skimming through the PR:
we've decided to limit the contexts in ssi-context to contexts that everybody would need, so probably the CLR context should be provided by the user; and
I would prefer jsonschema over boon, I understand boon appears to be more complete, but jsonschema has a larger user base and had been around for a while now.
@sbihel no worries! I'll just move the CLR context out of StaticLoader and then ad hoc use it for the test since I've already got that credential all set up. Should I do the same with the Open Badges contexts?
Also no worries about using jsonschema instead! I just went here and picked boon because it had more recent commits 😂
Okay, this now uses jsonschema, does not include CLR V2 context in StaticLoader, and adds an extra test to make sure that invalid schemas do fail. Let me know if you want me to move OBv3.0.1 and OBv3 Extensions contexts out of StaticLoader as well!
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for checking
credentialSchema.credentialSchema, that, when specified in options, will check thecredentialSchemafield of a credential.CheckableSchemaenum, similar to theCheckableStatusenum inssi-vcthat (for now) only supports 1EdTechJSONSchemaValidator2019 schemas, though boon supports much morecredential_schematest that makes sure everything is working!iri_matchmacro, complaining that a comma is missing. I have found that adding a comma like so fixes that:Feel free to remove that comma if necessary, I'm not really sure why it's happening to me as Rust macros still make my brain stop working a bit!
One more bit of reference: These are my cargo/rustc versions I am using and seeing that error with:
