feat: add TrimUI PyUI media and fn settings#1565
Open
vigstudio wants to merge 9 commits into
Open
Conversation
Expose fn_editor for Smart Pro family devices and mirror Smart Pro display color settings with safe sysfs fallbacks on Smart Pro S.
Launch the firmware TinaPlayer via /usr/trimui/apps/player from PyUI Apps, and drop the mistaken display calibration changes on Smart Pro S.
Replace stock firmware app launches with themed PyUI menus: video browser plus ffplay playback, and Smart Pro Fn or switch toggles. Hide the legacy VideoPlayer wrapper and keep stock fneditor on Brick only.
Lazy-import Video Player and Fn settings in app_menu, and defer MiyooTrimCommon import until playback.
vigstudio
marked this pull request as ready for review
July 2, 2026 10:05
chrisj951
reviewed
Jul 6, 2026
| brightness_up | ||
| fi | ||
| ;; | ||
| *"key $B_L3 1"*) # Left Fn key down |
Contributor
There was a problem hiding this comment.
Does the fn-key have the same keycode as L3/R3?
Even if it does this should be slightly refactored to
- Have a new export for fn-key instead of reusing l3/r3
- Make a call to fn_key_down/fn_key_up
- in device.sh just make empty fn_key_down/up methods like all the others in there
- move the run_fn_config into SmartProS.sh and this call into fn_key_down/up methods from (3)
chrisj951
reviewed
Jul 6, 2026
| return ControllerInput.R1 | ||
|
|
||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Are most of the line changes just line ending?
chrisj951
reviewed
Jul 6, 2026
| ".mp4", ".mkv", ".avi", ".mov", ".flv", ".ts", ".webm", | ||
| ".m4v", ".wmv", ".mpeg", ".mpg", ".3gp", | ||
| } | ||
| VIDEO_ROOT = "/mnt/SDCARD/Roms/MEDIA" |
Contributor
There was a problem hiding this comment.
Please update these to go through py-ui-config.json (located in App/PyUI/py-ui-config.json) and loaded through PyUiConfig.py
…ui-stock-settings # Conflicts: # App/PyUI/lang/English.json # App/PyUI/lang/Vietnamese.json # App/PyUI/main-ui/menus/app/app_menu.py
Author
|
Updated branch Changes addressed:
Validation run:
Note: |
Author
|
Created duplicate PyUI-only PR for MainPyUI: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
TrimUI Smart Pro/S users need PyUI-native access to stock-like video playback and Fn/DIP switch settings without falling back to the stock TrimUI UI. The stock CPU scene scripts also fail under spruceOS because CPU sysfs controls are locked and some stock frequencies are invalid on Smart Pro S, so Fn slider CPU performance mode does not apply reliably.
What Changed
/mnt/UDISK/system.json.buttons_watchdog.shto poll GPIO363 for Fn slider/DIP changes, run scene scripts, and stop prior scene script instances before starting new ones.Verification
git diff --checksuccessfully.python -m py_compilefortrimui_fn_settings_app.py,video_player_app.py, andapp_menu.pysuccessfully./tmp/buttons_watchdog_dip.logrecordedstate 1andstate 0transitions.performance 1992000 1992000for performance state and returns toondemand 1008000 1992000for normal state.