Document DaoAuthenticationProvider timing attack mitigation - #19532
Closed
AzazelSensei wants to merge 1 commit into
Closed
Document DaoAuthenticationProvider timing attack mitigation#19532AzazelSensei wants to merge 1 commit into
AzazelSensei wants to merge 1 commit into
Conversation
Note the user-not-found dummy PasswordEncoder path and the mixed-hash limitation in the DaoAuthenticationProvider and exploits docs. Closes spring-projectsgh-19082
Author
|
Superseded by clean branch: #19533 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gh-19082
Documents that
DaoAuthenticationProviderstill runs password validation through the configuredPasswordEncoderwhen a username is not found (dummy encoded password +matches), so the not-found path stays roughly in the same time range as a found path using that encoder.Also documents the limitation when a credential store mixes hash algorithms: Spring Security cannot pick one not-found duration that matches every found path, and upgrading stored passwords to a modern algorithm is the practical mitigation.
Changes
DaoAuthenticationProviderreference pageVerification
DaoAuthenticationProvider#retrieveUser,prepareTimingAttackProtection, andmitigateAgainstTimingAttack