docs: update few more documentation issues#50782
Open
doehyunbaek wants to merge 2 commits into
Open
Conversation
Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
Signed-off-by: Doehyun Baek <doehyunbaek@gmail.com>
c7bb3b5 to
863672b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found two documentation issues that still appear to be present on current
mainas of 2edca39.1. OTLP service connections are omitted from SSL support lists
The Docker Compose SSL support section lists supported service connections, but omits OpenTelemetry/OTLP logging, metrics, and tracing are omitted from dev-services.adoc and testcontainers.adoc
Introduced by:
2. External configuration docs show invalid
@ValuesyntaxThe external configuration docs use
@Value(${"my.service.enabled"}):spring-boot/documentation/spring-boot-docs/src/docs/antora/modules/reference/pages/features/external-config.adoc
Line 958 in 2edca39
But Java annotation values must be string literals. The placeholder should be inside the string:
@Value("${my.service.enabled}")Introduced by:
This PR fixes the above two issues.