Adds support for order-based array comparison #2401
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we're reusing the old property (spring.cloud.contract.verifier.assert.size) that can be set through system props or plugins. With this change finally there's an option to generate exact array verificaiton checks. Before the checks were indeed lazy, they assumed that any element should contain given values. Now they verify each element and its contents. Also this terrible JsonToJsonPathConverter class got cut into pieces and converted to Java. fixes spring-cloudgh-1927
we're reusing the old property (spring.cloud.contract.verifier.assert.size) that can be set through system props or plugins. With this change finally there's an option to generate exact array verificaiton checks. Before the checks were indeed lazy, they assumed that any element should contain given values. Now they verify each element and its contents. Also this terrible JsonToJsonPathConverter class got cut into pieces and converted to Java. fixes spring-cloudgh-1927
Contributor
Author
|
I'm leaving it as draft because I need to think this through still and thoroughly test it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #1927