Skip to content

Conversation

@Choosechee
Copy link
Contributor

I've replaced a use of the internal JUnit class org.junit.platform.commons.util.ClassUtils with a new custom org.spockframework.util.ClassUtilclass. This fixes issue #1227 (tested with my project).

@AndreasTu AndreasTu self-requested a review October 18, 2025 18:49
@AndreasTu AndreasTu added this to the 2.4-M7 milestone Oct 18, 2025
@AndreasTu AndreasTu linked an issue Oct 18, 2025 that may be closed by this pull request
Copy link
Member

@AndreasTu AndreasTu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Choosechee Thank you very much for your contribution.

@AndreasTu AndreasTu enabled auto-merge (squash) October 18, 2025 19:22
@AndreasTu AndreasTu disabled auto-merge October 18, 2025 19:36
@AndreasTu AndreasTu removed this from the 2.4-M7 milestone Oct 23, 2025
@AndreasTu AndreasTu requested a review from leonard84 November 28, 2025 14:22
@AndreasTu
Copy link
Member

AndreasTu commented Nov 28, 2025

@leonard84 I have fixed the review finding for the PR. Could you have another look please?
It would be great, if this would land in 2.4, because it also breaks the OSGi usage with JUnit 6 do the the same issue as the modules.

@AndreasTu
Copy link
Member

This PR will also fix #2231

@AndreasTu AndreasTu linked an issue Nov 28, 2025 that may be closed by this pull request
@AndreasTu AndreasTu added this to the 2.4 milestone Nov 28, 2025
@AndreasTu AndreasTu self-requested a review November 28, 2025 14:27
AndreasTu
AndreasTu previously approved these changes Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.14%. Comparing base (b8f0f84) to head (2ea89b1).

Files with missing lines Patch % Lines
...c/main/java/org/spockframework/util/ClassUtil.java 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2187   +/-   ##
=========================================
  Coverage     82.13%   82.14%           
- Complexity     4789     4794    +5     
=========================================
  Files           468      469    +1     
  Lines         14952    14961    +9     
  Branches       1888     1888           
=========================================
+ Hits          12281    12289    +8     
- Misses         1983     1984    +1     
  Partials        688      688           
Files with missing lines Coverage Δ
...ain/java/org/spockframework/runtime/SpockNode.java 80.85% <100.00%> (ø)
...c/main/java/org/spockframework/util/ClassUtil.java 88.88% <88.88%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leonard84 leonard84 enabled auto-merge (squash) November 30, 2025 14:39
@leonard84 leonard84 merged commit 95d433d into spockframework:master Nov 30, 2025
35 of 36 checks passed
@leonard84
Copy link
Member

Thanks @Choosechee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spock incompatible with JUnit 6 / OSGi Testing java modules throws java.lang.IllegalAccessError

3 participants