-
Notifications
You must be signed in to change notification settings - Fork 476
Issue #1227: Fix module testing not working due to call to JUnit internal API #2187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
AndreasTu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Choosechee Thank you very much for your contribution.
spock-core/src/main/java/org/spockframework/util/ClassUtil.java
Outdated
Show resolved
Hide resolved
spock-core/src/main/java/org/spockframework/util/ClassUtil.java
Outdated
Show resolved
Hide resolved
spock-specs/src/test/groovy/org/spockframework/util/ClassUtilSpec.groovy
Outdated
Show resolved
Hide resolved
spock-specs/src/test/groovy/org/spockframework/util/ClassUtilSpec.groovy
Show resolved
Hide resolved
Fixed review findings.
|
@leonard84 I have fixed the review finding for the PR. Could you have another look please? |
|
This PR will also fix #2231 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2187 +/- ##
=========================================
Coverage 82.13% 82.14%
- Complexity 4789 4794 +5
=========================================
Files 468 469 +1
Lines 14952 14961 +9
Branches 1888 1888
=========================================
+ Hits 12281 12289 +8
- Misses 1983 1984 +1
Partials 688 688
🚀 New features to boost your workflow:
|
|
Thanks @Choosechee |
I've replaced a use of the internal JUnit class
org.junit.platform.commons.util.ClassUtilswith a new customorg.spockframework.util.ClassUtilclass. This fixes issue #1227 (tested with my project).