Improve multimap getter/setter API in Go

benchmarks/encodings/parquet/parquet.go

@@ -128,11 +128,10 @@ func (d *Encoding) Encode(data encodings.InMemoryData) ([]byte, error) {
 
 func convertAttrs(attrs *otelstef.Attributes) (r []Attribute) {
 	for i := 0; i < attrs.Len(); i++ {
-		attr := attrs.At(i)
 		r = append(
 			r, Attribute{
-				Key:   attr.Key(),
-				Value: string(attr.Value().String()),
+				Key:   attrs.Key(i),
+				Value: string(attrs.Value(i).String()),
 			},
 		)
 	}

benchmarks/encodings/parquet/parquetz.go

@@ -211,11 +211,10 @@ func (d *EncodingZ) Encode(data encodings.InMemoryData) ([]byte, error) {
 
 func convertAttrsZ(attrs *otelstef.Attributes) (r []AttributeZ) {
 	for i := 0; i < attrs.Len(); i++ {
-		attr := attrs.At(i)
 		r = append(
 			r, AttributeZ{
-				Key:   attr.Key(),
-				Value: string(attr.Value().String()),
+				Key:   attrs.Key(i),
+				Value: string(attrs.Value(i).String()),
 			},
 		)
 	}

examples/jsonl/json2stef.go

@@ -29,7 +29,7 @@ func convertToJsonValue(src interface{}, dst *jsonstef.JsonValue) {
 
 		for _, k := range keys {
 			obj.SetKey(i, k)
-			convertToJsonValue(v[k], obj.At(i).Value())
+			convertToJsonValue(v[k], obj.Value(i))
 			i++
 		}
 		//obj.Sort()

examples/profile/pprof2stef.go

@@ -125,7 +125,7 @@ func (c *pprof2stef) convertSample(srcSample *profile.Sample, srcProf *profile.P
 	for key, values := range srcSample.Label {
 		for _, value := range values {
 			dstLabels.SetKey(labelIndex, key)
-			dstLabelValue := dstLabels.At(labelIndex).Value()
+			dstLabelValue := dstLabels.Value(labelIndex)
 			dstLabelValue.SetStr(value)
 			labelIndex++
 		}
@@ -135,7 +135,7 @@ func (c *pprof2stef) convertSample(srcSample *profile.Sample, srcProf *profile.P
 	for key, values := range srcSample.NumLabel {
 		for _, value := range values {
 			dstLabels.SetKey(labelIndex, key)
-			dstLabelValue := dstLabels.At(labelIndex).Value()
+			dstLabelValue := dstLabels.Value(labelIndex)
 			dstLabelValue.SetType(stefprofile.LabelValueTypeNum)
 			numValue := dstLabelValue.Num()
 			numValue.SetVal(value)

examples/profile/stef2pprof.go

@@ -170,8 +170,8 @@ func convertStefToPprof(src io.Reader) (*profile.Profile, error) {
 
 		stefLabels := reader.Record.Labels()
 		for i := 0; i < stefLabels.Len(); i++ {
-			key := stefLabels.At(i).Key()
-			stefLabelValue := stefLabels.At(i).Value()
+			key := stefLabels.Key(i)
+			stefLabelValue := stefLabels.Value(i)
 
 			if stefLabelValue.Type() == stefprofile.LabelValueTypeStr {
 				value := stefLabelValue.Str()

go/otel/manual_test.go

@@ -139,7 +139,7 @@ func mapToTef(m map[string]any, out *otelstef.Attributes) {
 	sort.Strings(keys)
 
 	for _, k := range keys {
-		valueToTef(m[k], out.At(i).Value())
+		valueToTef(m[k], out.Value(i))
 		out.SetKey(i, k)
 		i++
 	}
@@ -184,7 +184,7 @@ func valueToTef(v any, into *otelstef.AnyValue) {
 		i := 0
 		for k, v := range val {
 			kvList.SetKey(i, k)
-			valueToTef(v, kvList.At(i).Value())
+			valueToTef(v, kvList.Value(i))
 		}
 
 	default:
@@ -196,9 +196,8 @@ func tefToMap(in *otelstef.Attributes) map[string]any {
 	out := map[string]any{}
 
 	for i := 0; i < in.Len(); i++ {
-		kv := in.At(i)
-		val := tefToValue(kv.Value())
-		out[kv.Key()] = val
+		val := tefToValue(in.Value(i))
+		out[in.Key(i)] = val
 	}
 	return out
 }
@@ -236,9 +235,8 @@ func tefToValue(src *otelstef.AnyValue) any {
 		values := map[string]any{}
 		kvList := src.KVList()
 		for i := 0; i < kvList.Len(); i++ {
-			pair := kvList.At(i)
-			val := tefToValue(pair.Value())
-			values[pair.Key()] = val
+			val := tefToValue(kvList.Value(i))
+			values[kvList.Key(i)] = val
 		}
 		return values
 
@@ -410,7 +408,7 @@ func TestLargeMultimap(t *testing.T) {
 	attrs.EnsureLen(attrCount)
 	for i := 0; i < attrCount; i++ {
 		attrs.SetKey(i, strconv.Itoa(i))
-		attrs.At(i).Value().SetInt64(int64(i))
+		attrs.Value(i).SetInt64(int64(i))
 	}
 	var attrs1Copy otelstef.Attributes
 	attrs1Copy.CopyFrom(attrs)
@@ -420,7 +418,7 @@ func TestLargeMultimap(t *testing.T) {
 	// Modify one key. This normally would result in differential encoding
 	// but since the multimap is large it will use full encoding. This is
 	// precisely the case that this test verifies.
-	attrs.At(0).Value().SetString("abc")
+	attrs.Value(0).SetString("abc")
 	var attrs2Copy otelstef.Attributes
 	attrs2Copy.CopyFrom(attrs)
 	err = w.Write()

go/pdata/internal/otlptools/otlpval2tef.go

@@ -82,7 +82,7 @@ func (o *Otlp2Stef) MapSorted(m pcommon.Map, out *otelstef.Attributes) {
 
 	out.EnsureLen(m.Len())
 	for i := range o.attrElems {
-		otlpValueToTefAnyValue(o.attrElems[i].val, out.At(i).Value())
+		otlpValueToTefAnyValue(o.attrElems[i].val, out.Value(i))
 		out.SetKey(i, o.attrElems[i].str)
 	}
 }
@@ -92,7 +92,7 @@ func (o *Otlp2Stef) MapUnsorted(m pcommon.Map, out *otelstef.Attributes) {
 	i := 0
 	m.Range(
 		func(k string, v pcommon.Value) bool {
-			otlpValueToTefAnyValue(v, out.At(i).Value())
+			otlpValueToTefAnyValue(v, out.Value(i))
 			out.SetKey(i, k)
 			i++
 			return true
@@ -138,7 +138,7 @@ func otlpValueToTefAnyValue(val pcommon.Value, into *otelstef.AnyValue) {
 		val.Map().Range(
 			func(k string, v pcommon.Value) bool {
 				kvList.SetKey(i, k)
-				otlpValueToTefAnyValue(v, kvList.At(i).Value())
+				otlpValueToTefAnyValue(v, kvList.Value(i))
 				return true
 			},
 		)

go/pdata/internal/otlptools/tef2otlpval.go

@@ -29,10 +29,8 @@ func TefToOtlpMap(in *otelstef.Attributes, out pcommon.Map) error {
 
 	//decoder := anyvalue.Decoder{}
 	for i := 0; i < in.Len(); i++ {
-		kv := in.At(i)
-		val := out.PutEmpty(kv.Key())
-		//decoder.Reset(anyvalue.ImmutableBytes(kv.Value()))
-		err := tefAnyValueToOtlp(kv.Value(), val)
+		val := out.PutEmpty(in.Key(i))
+		err := tefAnyValueToOtlp(in.Value(i), val)
 		if err != nil {
 			return err
 		}
@@ -77,9 +75,8 @@ func tefAnyValueToOtlp(anyVal *otelstef.AnyValue, into pcommon.Value) error {
 		values := into.SetEmptyMap()
 		kvList := anyVal.KVList()
 		for i := 0; i < kvList.Len(); i++ {
-			pair := kvList.At(i)
-			val := values.PutEmpty(pair.Key())
-			err := tefAnyValueToOtlp(pair.Value(), val)
+			val := values.PutEmpty(kvList.Key(i))
+			err := tefAnyValueToOtlp(kvList.Value(i), val)
 			if err != nil {
 				return err
 			}