-
-
Notifications
You must be signed in to change notification settings - Fork 807
feat(css-map): add player classes for 1.2.75
#3558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughAdds numerous new key-to-CSS mappings to css-map.json across many UI areas, including cover art, action bars/cards, avatars/images, entity headers, top bar/root scaffolding, playback/now-playing, track lists, and volume/sort controls. No removals or modifications to existing exports are indicated. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
css-map.json (2)
1108-1142
: TrackInfo: artists/container/contentWrapper/enhanced/name/overlay/xsmallBadges.Public names look correct; two distinct “name” keys added—likely intentional aliases.
Consider adding a tiny comment in release notes mapping which public names changed in 1.2.75 to speed future maintenance.
1-1921
: Add CI validation for css-map.json to detect duplicate keys and enforce key/value formatIntegrate a lightweight script (e.g., the provided Python check) into your CI pipeline to catch silent JSON key overrides and invalid key/value patterns early.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
css-map.json
(39 hunks)
🔇 Additional comments (17)
css-map.json (17)
124-132
: Cover art mappings look consistent with 1.2.75 (16-char keys).New keys for cover-art/icon/image appear correct and consistent.
190-199
: Action bar additions align with existing naming.ActionBar, Row, and exploreButton mappings follow established conventions; no issues spotted.
225-231
: Avatar/image mappings OK.main-avatar-avatar and main-avatar-image entries use 16-char keys and match prior patterns.
285-324
: Card/cardTitle/imageContainer/PlayButtonContainer/imageWrapper: spot check OK.Mappings for card and image wrappers look coherent; no obvious typos in public names.
Please validate these are the only new keys for card/imagery in 1.2.75 and that legacy keys were retained for older versions.
412-423
: Cover slot collapsed controls appear consistent.container, expandButton, and navAltContainer mappings read fine.
566-656
: Entity header block: large set of new keys—looks internally consistent.backgroundColor, container, creatorWrapper, headerText, image*, metaData*, pretitle, shadow, title, topbar*, genericButton all follow existing naming; 16-char obfuscated keys observed.
- Confirm no duplicate JSON keys across this block (duplicates would silently override).
- Ensure all newly referenced selectors are actually used by features relying on entity header (e.g., header actions, image clickability).
724-729
: main-image loaded state mappings OK.image and loaded classes updated; consistent.
789-822
: Now playing bar: center/container/extraControls/left/lyricsButton/right/volumeBar.Names look right; breadth of additions should restore most NPV/controls behavior.
Please verify UI interactions (lyrics button, volume) after this change with 1.2.75.
893-900
: Now playing widget “nowPlaying” mapping added.Matches naming; no issues.
902-914
: Playback remaining time + play button.Container and PlayButton mappings align with prior structure.
1018-1065
: Top bar: background/container/overlay/topbarContent/Wrapper.Additions look consistent and should cover scroll/overlay states.
Confirm overlay z-index/stacking assumptions in features that toggle blur/overlay still hold with these classes.
1149-1304
: TrackList: columns, duration, indexable, number, row sections, headers.*Large, coherent set; naming consistent with existing conventions.
- Smoke-test sort/resizing/duration rendering with these mappings.
- Ensure rowMainContent/rowMarker/grid/header “stuck” states function after upgrade.
1475-1500
: Playback bar/progressbar + player controls.Additions look correct; interactive flags preserved (isInteractive).
Verify keyboard navigation and focus styles still bind to the updated classes.
1614-1626
: Root scaffolding: main-view/nav-bar/now-playing-bar/top-container.Consistent with prior structure; no issues.
1753-1764
: Volume bar and slider-container.Mappings align with expected control structure.
1814-1822
: x-progressBar: fillColor/progressBarBg/sliderArea.Looks good; consistent with other progress components.
1909-1913
: x-sortBox: text and sortDropdown.OK. Good to see both text and dropdown updated together.
Add classes for 1.2.75
There is a need to map all of class names to be added as they changed className length to 16 from 20 in the new update.
Most of the things are broken on the new update
Summary by CodeRabbit