Skip to content

Conversation

sanoojes
Copy link
Contributor

@sanoojes sanoojes commented Oct 14, 2025

Add classes for 1.2.75

There is a need to map all of class names to be added as they changed className length to 16 from 20 in the new update.

Most of the things are broken on the new update

Summary by CodeRabbit

  • Style
    • Expanded styling coverage across the app, including cover art, avatars, entity headers, and top bar.
    • Improved visuals and consistency for action bars, playback and now playing components.
    • Enhanced presentation for track lists and list items.
    • Refined controls for volume and sorting for a more cohesive look and feel.
    • General UI polish to improve consistency and responsiveness across components.

Copy link

coderabbitai bot commented Oct 14, 2025

Walkthrough

Adds numerous new key-to-CSS mappings to css-map.json across many UI areas, including cover art, action bars/cards, avatars/images, entity headers, top bar/root scaffolding, playback/now-playing, track lists, and volume/sort controls. No removals or modifications to existing exports are indicated.

Changes

Cohort / File(s) Summary of edits
Cover art and imagery
css-map.json
Added mappings for cover-art related keys (e.g., s1ft0kHOwOh71ov_, JHEcxruRuoEItJ1J, XKSrCjmdPkrllkPc).
Action bar and cards
css-map.json
Added main action bar and card-related mappings (F2fAYJQIt4kVkkHt, Hln1Dms3QOQ7pvLw, WeMORGvkBnszLgAA, RPV24T758a0OhKtZ, mGpHyHUUZ0wzRQEv, YR9YVGItxfIgAZje, qpns1iHTAt8rMNnK, main-card-, main-cardImage-).
Avatars and images
css-map.json
Added main avatar/image entries (L7jLHC4iWwoShHzX, hdfu3dPuuRgPc8xx).
Entity header visuals
css-map.json
Added header-related mappings (XT oncn4_mYHzhKy7, P2bsavgZEZcO4YZh, NkEpAlqumQAgJJ1Y, NNafsIKjQaOOVJsH, FYDVy8qxy_QugEOZ, dicrc5_MWcv63llC, Ybke9Ht_PucWrF_k, i_8d_eU6XnQ4GlE2, _EuXSrqTA94N1Evn).
Top bar and root scaffolding
css-map.json
Added top bar/root view keys (AGRpGUcmqIgVZ5Nh, NXttmW3KPwE1r4Am, FdWkUygeG4YIau9k, iRGr6yO6lPcAKUoT, LTqMCWXd5Nkemkym).
Playback and now-playing
css-map.json
Added playback/now-playing mappings (o9SONbmdTWwKgbUo, playback-bar-, main-playButton-PlayButton, main-nowPlayingBar-, main-nowPlayingWidget-nowPlaying).
Track lists and items
css-map.json
Added track/list mappings (gEuCRW7HpVsFA80I, xGX3wwPnlgoLZTP0, xSfZMAalZIg2nzIs, Cz0_emqDhTg390Au, jEiAs1et4fAU3chW, Na06TEk5cCR4FwBd, Q4mk1oUBywa1PuZZZ0Mr, Os5g1cBfm5EEYTxX, etc.).
Volume and sort controls
css-map.json
Added volume/sort box entries (gN7X0A3rvrI2fb0I, f6jYIQ_DFwRILHk0, MAVtcS16N9A0EmPX, s0io0qfDcnYp3WZ2, oiCAtqC3axe0E7pii8XJ, LQ6y2jhZZtMS7xCr).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • kyrie25
  • rxri

Poem

I hop through hashes, ears held high,
New maps sprout like stars in sky—
Covers, bars, and buttons sing,
Playback thumps with bounding spring.
A nibble of CSS, a twitch of nose—
The UI garden blooms and grows. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly conveys that this PR adds new player class mappings to the css-map for version 1.2.75, directly reflecting the main purpose of restoring functionality after the className length change in the update.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
css-map.json (2)

1108-1142: TrackInfo: artists/container/contentWrapper/enhanced/name/overlay/xsmallBadges.

Public names look correct; two distinct “name” keys added—likely intentional aliases.

Consider adding a tiny comment in release notes mapping which public names changed in 1.2.75 to speed future maintenance.


1-1921: Add CI validation for css-map.json to detect duplicate keys and enforce key/value format

Integrate a lightweight script (e.g., the provided Python check) into your CI pipeline to catch silent JSON key overrides and invalid key/value patterns early.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 15d1365 and ab83f4e.

📒 Files selected for processing (1)
  • css-map.json (39 hunks)
🔇 Additional comments (17)
css-map.json (17)

124-132: Cover art mappings look consistent with 1.2.75 (16-char keys).

New keys for cover-art/icon/image appear correct and consistent.


190-199: Action bar additions align with existing naming.

ActionBar, Row, and exploreButton mappings follow established conventions; no issues spotted.


225-231: Avatar/image mappings OK.

main-avatar-avatar and main-avatar-image entries use 16-char keys and match prior patterns.


285-324: Card/cardTitle/imageContainer/PlayButtonContainer/imageWrapper: spot check OK.

Mappings for card and image wrappers look coherent; no obvious typos in public names.

Please validate these are the only new keys for card/imagery in 1.2.75 and that legacy keys were retained for older versions.


412-423: Cover slot collapsed controls appear consistent.

container, expandButton, and navAltContainer mappings read fine.


566-656: Entity header block: large set of new keys—looks internally consistent.

backgroundColor, container, creatorWrapper, headerText, image*, metaData*, pretitle, shadow, title, topbar*, genericButton all follow existing naming; 16-char obfuscated keys observed.

  • Confirm no duplicate JSON keys across this block (duplicates would silently override).
  • Ensure all newly referenced selectors are actually used by features relying on entity header (e.g., header actions, image clickability).

724-729: main-image loaded state mappings OK.

image and loaded classes updated; consistent.


789-822: Now playing bar: center/container/extraControls/left/lyricsButton/right/volumeBar.

Names look right; breadth of additions should restore most NPV/controls behavior.

Please verify UI interactions (lyrics button, volume) after this change with 1.2.75.


893-900: Now playing widget “nowPlaying” mapping added.

Matches naming; no issues.


902-914: Playback remaining time + play button.

Container and PlayButton mappings align with prior structure.


1018-1065: Top bar: background/container/overlay/topbarContent/Wrapper.

Additions look consistent and should cover scroll/overlay states.

Confirm overlay z-index/stacking assumptions in features that toggle blur/overlay still hold with these classes.


1149-1304: TrackList: columns, duration, indexable, number, row sections, headers.*

Large, coherent set; naming consistent with existing conventions.

  • Smoke-test sort/resizing/duration rendering with these mappings.
  • Ensure rowMainContent/rowMarker/grid/header “stuck” states function after upgrade.

1475-1500: Playback bar/progressbar + player controls.

Additions look correct; interactive flags preserved (isInteractive).

Verify keyboard navigation and focus styles still bind to the updated classes.


1614-1626: Root scaffolding: main-view/nav-bar/now-playing-bar/top-container.

Consistent with prior structure; no issues.


1753-1764: Volume bar and slider-container.

Mappings align with expected control structure.


1814-1822: x-progressBar: fillColor/progressBarBg/sliderArea.

Looks good; consistent with other progress components.


1909-1913: x-sortBox: text and sortDropdown.

OK. Good to see both text and dropdown updated together.

@sanoojes sanoojes marked this pull request as draft October 14, 2025 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant