Open
Conversation
Contributor
Author
Attributes
Has One / Belongs To
Has Many
|
While implementing this feature, I realised there is a bit of logic to the conditional rendering. This made `Serializer#as_json` bloat in complexity. To address the added complexity, I extracted out the `Attribute` and `Association` classes. This provides an added benefit of the `Attribute` and `Association` classes defining the `#included?` method, which checks depth vs max_depth, along with user defined conditions.
7f07505 to
4a01b6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The following issues go into the detail of the need for these changes:
Essentially, we need a way to render attributes only when they need to be included. This is useful for
Concerns and considerations
Changes
AttributeandAssociationclasses.if:andunless:SymbolorProcvalues.