Skip to content

feat: add beforeunload event #7631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
grantfitzsimmons wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Draft

feat: add beforeunload event #7631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions specifyweb/frontend/js_src/lib/components/Forms/ResourceView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,16 @@ export function ResourceView<SCHEMA extends AnySchema>({

const isModified = useIsModified(resource);

React.useEffect(() => {
if (!isModified) return;
const handleBeforeUnload = (event: BeforeUnloadEvent): void => {
event.preventDefault();
event.returnValue = '';
};
window.addEventListener('beforeunload', handleBeforeUnload);
return () => window.removeEventListener('beforeunload', handleBeforeUnload);
}, [isModified]);

const [showUnloadProtect, setShowUnloadProtect] = React.useState(false);

const [makeFormDialogsModal] = userPreferences.use(
Expand Down
4 changes: 1 addition & 3 deletions specifyweb/specify/models_utils/relationships.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,6 @@ def _handle_remote_fk_field(obj, field, value, read_checker):

elif isinstance(value, field.related_model):
# The related value was patched into the data by a parent object.
setattr(obj, field_name, value)
rel_data = _obj_to_data(value, read_checker)
new_related_id = value.id

Expand All @@ -218,7 +217,6 @@ def _handle_remote_fk_field(obj, field, value, read_checker):
assert not dependent, f"didn't get inline data for dependent field {field_name} in {obj}: {value!r}"
fk_model, fk_id = strict_uri_to_model(value, field.related_model.__name__)
rel_obj = get_object_or_404(fk_model, id=fk_id)
setattr(obj, field_name, rel_obj)
rel_data = _obj_to_data(rel_obj, read_checker)
new_related_id = rel_obj.pk

Expand All @@ -234,7 +232,7 @@ def _handle_remote_fk_field(obj, field, value, read_checker):
if str(old_related_id) != str(new_related_id):
dirty.append(FieldChangeInfo(field_name=field_name, old_value=old_related_id, new_value=new_related_id))

if not rel_data is None:
if rel_data is not None:
remote_to_ones.append((field.remote_field, rel_data, dependent))
return dependents_to_delete, dirty, remote_to_ones

Expand Down