Remove ISR to make site fully static#1752
Merged
Merged
Conversation
This project is archived with no new content. Removing ISR eliminates background revalidation that costs ~$5/month in serverless function duration and ISR writes. - Remove revalidate from all getStaticProps - Set fallback: false on dynamic routes (no new paths needed) - Remove unused search API route Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
fallback: false returns 404 for paths not in getStaticPaths, breaking episode pages and invalid slug redirects. 'blocking' generates on first request and caches forever (no revalidate = no ongoing ISR cost). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fallback: 'blocking' triggers Simplecast API calls via isomorphic-unfetch which throws 'Aborted is not defined' on modern Node.js. Since the project is archived, use fallback: false (404 for non-pre-generated paths) and remove tests that depend on runtime fallback behavior: - Delete episode_spec.ts (episodes aren't pre-generated) - Remove invalid podcast test (fallback: false returns 404, not redirect) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
isomorphic-unfetch uses node-fetch which references a global 'Aborted' class removed in Node.js 18+. The CI runs on ubuntu-latest (Node 22) which triggers this on every page. Since the project is archived, suppress rather than upgrade the dependency. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
revalidatefrom allgetStaticProps— pages are built once at deploy time and cached foreverfallback: falseon dynamic routes — no new podcast episodes will be addedContext
This project is archived and no longer receives content updates. ISR was costing ~$5/month in unnecessary function duration (13.6 GB-hours), ISR writes (246K), and function invocations (147K) for background revalidation of pages that never change.
Test plan
🤖 Generated with Claude Code