feat: add instructions for NPM Trusted Publishing #1685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2ynn
commented
Oct 31, 2025
2ynn
commented
Oct 31, 2025
| var publishPaths, generationWorkflowFilePaths []string | ||
| workflowPaths := make(map[string]targetWorkflowPaths) | ||
|
|
||
| for _, name := range chosenTargets { |
Contributor
Author
There was a problem hiding this comment.
chosenTargets variable is currently confusing. When multiple targets are set up in the same repository:
then selecting one or the other makes no difference since both workflow files will get updated:
2ynn
force-pushed
the
cs-275/npm-trusted-publishing
branch
4 times, most recently
from
abc171a to
f10eb3f
Compare
2ynn
force-pushed
the
cs-275/npm-trusted-publishing
branch
from
f10eb3f to
31705ae
Compare
mfbx9da4
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CS-275
RFC
Sample output for a single target (
prmode ->sdk_publish.yaml)Sample output for a single target (
directmode ->sdk_generation.yaml)Sample output for 2 targets in the same repo (
typescript+mcp-typescript)