Skip to content

Scheduler does not obey Stream.push api #60

Description

@jacobheun

Currently when the Scheduler ticks it will run through all chunks for all scheduled items and push the chunks onto the stream. The resulting Boolean from push is not checked for every chunk, which can result in an error if pushes become disallowed during the tick.

The problem lines are
https://github.com/spdy-http2/spdy-transport/blob/v2.1.1/lib/spdy-transport/protocol/base/scheduler.js#L124
and
https://github.com/spdy-http2/spdy-transport/blob/v2.1.1/lib/spdy-transport/protocol/base/scheduler.js#L164

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions