Update DateTime pattern to follows ISO 8601:2019#1245
Open
bact wants to merge 2 commits into
Open
Conversation
The new pattern will restrict: - month to 01-12 - date to 01-31 - hour to 00-23 - minute to 00-59 - second to 00-60 This restrictions are aligned with ISO 8601:2019. Note that the "60" second is reserved only for the positive leap second. See Clause 3.1.1.24 of ISO 8601:2019. Based on changes in SPDX 2.3.1 draft spdx/spdx-spec#1377 Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com> Co-Authored-By: zbleness <77726616+zbleness@users.noreply.github.com>
zvr
requested changes
Apr 8, 2026
per review. Also strict the leap second to 23:59:60 Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the string pattern of
DateTime. The new pattern will restrict:These restrictions are aligned with ISO 8601:2019, which the
DateTimeis referenced to.Note that the "60" second is reserved only for the positive leap second at 23:59:60. See ISO 8601:2019 Clause 3.1.1.24 https://www.iso.org/obp/ui/#iso:std:iso:8601:-1:ed-1:v1:en and RFC 3339 Appendix D https://www.rfc-editor.org/rfc/rfc3339.html#appendix-D
Based on changes in SPDX 2.3.1 draft spdx/spdx-spec#1377