Skip to content

deploy: Arbitrum One Staging V1.10.0 - #256

Open
deluca-mike wants to merge 1 commit into
devfrom
deploy/arbitrum-staging-10
Open

deploy: Arbitrum One Staging V1.10.0#256
deluca-mike wants to merge 1 commit into
devfrom
deploy/arbitrum-staging-10

Conversation

@deluca-mike

@deluca-mike deluca-mike commented Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores
    • Enhanced deployment process with improved staging environment detection and explicit deployer logging
    • Added Arbitrum One staging release configuration for version 20260619

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 049613b5-e421-49eb-91ed-14053081d9ed

📥 Commits

Reviewing files that changed from the base of the PR and between ce5cbd9 and c4a7134.

📒 Files selected for processing (2)
  • script/Deploy.s.sol
  • script/output/1/arbitrum_one-staging-release-20260619.json

Walkthrough

DeployForeignController.run is updated to select the fork earlier, detect isStaging from the ENV variable with distinct console logs, use an explicit PRIVATE_KEY for broadcasting, and log the deployer address via vm.readCallers(). A new staging deployment JSON artifact for Arbitrum One is also added.

Changes

DeployForeignController Staging Flow

Layer / File(s) Summary
Staging detection, broadcast, and deployer logging
script/Deploy.s.sol
Fork selection moved earlier; isStaging flag derived from ENV drives separate console log messages; vm.startBroadcast switched to use explicit PRIVATE_KEY env var; deployer address logged via vm.readCallers() before config is loaded.
Staging deployment artifact
script/output/1/arbitrum_one-staging-release-20260619.json
New JSON file recording the deployed controller address for the Arbitrum One staging release on 2026-06-19.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • sparkdotfi/spark-alm-controller#255: Applies the same isStaging/ENV branching and explicit PRIVATE_KEY broadcast pattern with vm.readCallers() deployer logging to the same run() deployment logic in script/Deploy.s.sol.

Suggested reviewers

  • supercontracts
  • lucas-manuel

Poem

🐇 Hippity-hop, the staging flag is set,
A private key broadcast, no worries yet!
The deployer's address logged with care,
The controller artifact placed just there.
From fork selection to JSON delight —
This rabbit's deploy went perfectly right! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'deploy: Arbitrum One Staging V1.10.0' follows the required format (starts with a descriptive prefix and colon) and accurately reflects the main changes in the pull request, which involve deployment configuration updates for Arbitrum One staging environment.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deploy/arbitrum-staging-10

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant