Add new step slit_cube_build for building NIRSpec MSA cubes - #10818
Draft
jemorrison wants to merge 4 commits into
Draft
jemorrison wants to merge 4 commits into
jemorrison wants to merge 4 commits into
Conversation
jemorrison
marked this pull request as draft
August 24, 2026 17:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps to resolve JP-4388
This PR is a draft - submitted to get early feed back. There are some print statements that have been left to aid in testing that need to be removed and few other issue that need to be cleaned up.
This PR addresses add a new step, slit_cube_build, to create NIRSpec MSA cubes.
By default MSA cube build will weight by overlap volume and build cubes in a "drizzle fashion". There is a desire to
add read noise weighting. There is a module msa_cube_overlap.py that is just temporary. This code performs drizzle cube building weighting by overlap area and read noise. The cube_build C routines need to be updated to allow weighting by read noise. For this PR I can remove the option to weight by read noise and run this module. Or we can update the C cube build code
to allow this.
In addition we should create a new output model 'msacube'. Currently we are using the ifucube model, but there are some new
parameters (slit_frac) that are not part of the ifucube model that we need to record and we are creating a new plane called
ETIME (which can be used to find the effective exposure time of very spaxel).
There is a PR out for cube_build changing how the DQ plane is formed. Once that is merged we need to add some of the hooks
in the code (IF DESIRED) to send saturated data to the C code.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files