JP-1276: Add input exposure type validation to pipelines - #10816
Open
melanieclarke wants to merge 5 commits into
Open
melanieclarke wants to merge 5 commits into
melanieclarke wants to merge 5 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10816 +/- ##
=======================================
Coverage 87.86% 87.87%
=======================================
Files 372 372
Lines 40361 40390 +29
=======================================
+ Hits 35464 35493 +29
Misses 4897 4897 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Regtests: All passing, but additional tests with SDP and/or INS would be helpful, in case there are unusual but supported exposure types we're not testing in the regression tests. |
Collaborator
Author
|
@tapastro - I mentioned this in the meeting just now, but to add it here too: it would be useful to do some integration testing for this one with SDP in case there are valid exposure types I've missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JP-1276
Check input exposure types at the beginning of stage 2 and 3 pipelines. Raise a TypeError if the input does not match an expected list of exposure types.
For tso3, there was already some input validation to check if the first exposure was TSO-type. For this pipeline, I kept the check for TSO types instead of exposure types, but expanded the check to all input models and raised a TypeError instead of returning None.
I did not add any checks for the stage 1 pipelines -- these are either very permissive (detector1) or very specialized (dark, guider), so user input mistakes seem less likely.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)changes/<PR#>.breaking.rstnews fragmentdocs/pageokify_regteststo update the truth files