Skip to content

JP-1276: Add input exposure type validation to pipelines - #10816

Open
melanieclarke wants to merge 5 commits into
spacetelescope:mainfrom
melanieclarke:jp-1276
Open

melanieclarke wants to merge 5 commits into
spacetelescope:mainfrom
melanieclarke:jp-1276

Conversation

@melanieclarke

@melanieclarke melanieclarke commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Resolves JP-1276

Check input exposure types at the beginning of stage 2 and 3 pipelines. Raise a TypeError if the input does not match an expected list of exposure types.

For tso3, there was already some input validation to check if the first exposure was TSO-type. For this pipeline, I kept the check for TSO types instead of exposure types, but expanded the check to all input models and raised a TypeError instead of returning None.

I did not add any checks for the stage 1 pipelines -- these are either very permissive (detector1) or very specialized (dark, guider), so user input mistakes seem less likely.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@melanieclarke melanieclarke added this to the Build 13.2 milestone Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.87%. Comparing base (125f9c4) to head (8a3ec5d).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10816   +/-   ##
=======================================
  Coverage   87.86%   87.87%           
=======================================
  Files         372      372           
  Lines       40361    40390   +29     
=======================================
+ Hits        35464    35493   +29     
  Misses       4897     4897           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@melanieclarke

Copy link
Copy Markdown
Collaborator Author

Regtests:
https://github.com/spacetelescope/RegressionTests/actions/runs/32379312831

All passing, but additional tests with SDP and/or INS would be helpful, in case there are unusual but supported exposure types we're not testing in the regression tests.

@melanieclarke
melanieclarke marked this pull request as ready for review August 20, 2026 18:19
@melanieclarke
melanieclarke requested a review from a team August 20, 2026 18:19
@melanieclarke

Copy link
Copy Markdown
Collaborator Author

@tapastro - I mentioned this in the meeting just now, but to add it here too: it would be useful to do some integration testing for this one with SDP in case there are valid exposure types I've missed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants