Skip to content

JP-4275: Store tweaked imaging WCS objects in mosaic for transfer to WFSS spectral images in assign_wcs - #10593

Draft
tapastro wants to merge 8 commits into
spacetelescope:mainfrom
tapastro:jp-4275-transfer-wcs-corr
Draft

tapastro wants to merge 8 commits into
spacetelescope:mainfrom
tapastro:jp-4275-transfer-wcs-corr

Conversation

@tapastro

@tapastro tapastro commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Partially resolves JP-4275

This PR stores mosaic members' WCS objects along with their RA/Dec reference positions in i2d mosaic files. During processing of WFSS dispersed images, the WCS of the reference position closest to the dispersed image position is used in place of a fresh imaging WCS upon which we place the dispersed trace transform.

Tasks

  • If you have a specific reviewer in mind, tag them.
  • add a build milestone, i.e. Build 12.0 (use the latest build if not sure)
  • Does this PR change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see changelog readme for instructions)
      • if your change breaks step-level or public API (as defined in the docs), also add a changes/<PR#>.breaking.rst news fragment
    • update or add relevant tests
    • update relevant docstrings and / or docs/ page
    • start a regression test and include a link to the running job (click here for instructions)
      • Do truth files need to be updated ("okified")?
        • after the reviewer has approved these changes, run okify_regtests to update the truth files
  • if a JIRA ticket exists, make sure it is resolved properly

@codecov

codecov Bot commented Jun 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.85714% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.02%. Comparing base (1255ce1) to head (e5b76c4).

Files with missing lines Patch % Lines
jwst/assign_wcs/util.py 40.00% 18 Missing ⚠️
jwst/assign_wcs/niriss.py 28.57% 5 Missing ⚠️
jwst/resample/resample_step.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10593      +/-   ##
==========================================
- Coverage   87.86%   86.02%   -1.85%     
==========================================
  Files         372      372              
  Lines       40365    40403      +38     
==========================================
- Hits        35468    34756     -712     
- Misses       4897     5647     +750     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tapastro
tapastro force-pushed the jp-4275-transfer-wcs-corr branch from daa52df to df162ec Compare July 13, 2026 17:53
@tapastro
tapastro force-pushed the jp-4275-transfer-wcs-corr branch 3 times, most recently from e71da5c to 83368e2 Compare August 11, 2026 15:11
@tapastro
tapastro force-pushed the jp-4275-transfer-wcs-corr branch from b819ee5 to 49f0bd1 Compare September 2, 2026 14:42
@tapastro
tapastro force-pushed the jp-4275-transfer-wcs-corr branch from 49f0bd1 to e5b76c4 Compare September 2, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant