Skip to content

Fix background result relay delivery - #652

Open
jamiepine wants to merge 1 commit into
jamiepine/autonomy-toggle-commandsfrom
jamiepine/background-result-relay-delivery
Open

Fix background result relay delivery#652
jamiepine wants to merge 1 commit into
jamiepine/autonomy-toggle-commandsfrom
jamiepine/background-result-relay-delivery

Conversation

@jamiepine

Copy link
Copy Markdown
Member

Stacked on #651.

Summary

  • confirm replies, questions, and files at the messaging adapter before acknowledging background results
  • retry failed result relays once, keep exhausted results queued, and retry them after the next user turn
  • discard retrigger scaffolding and failed reply text instead of persisting internal instructions in conversation history
  • terminate completed file deliveries cleanly and reject unsupported adapter payloads

Delivery transitions converge as pending -> in flight -> delivered or pending -> in flight -> retry pending -> deferred. Adapter calls are capped at 30 seconds and receipt waits at 60 seconds. Duplicate completion batches remain ordered in the deferred queue, and only confirmed deliveries mark status items relayed.

Testing

  • just preflight
  • just gate-pr
  • cargo test agent::channel_history::tests
  • cargo test tools::send_file::tests
  • cargo test routed_sender_
  • adapter tests for Mattermost, Portal, and Twitch

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 26325663-acaa-4fc2-b840-b441dcc2467f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jamiepine
jamiepine marked this pull request as ready for review August 17, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant