Open
Conversation
dd0537a to
191b71c
Compare
Author
|
ping? Does this look sensible? |
This ensures that pushing works even when users have configured their global gitconfig to always use SSH for pushing: using the entry `url.git@github.com:.pushinsteadof=https://github.com/`
spacedentist
approved these changes
Jan 23, 2026
Owner
spacedentist
left a comment
There was a problem hiding this comment.
Happy to merge this - if you can just do the one change in the comments.
This fixes pushing to a remote configured to use SSH instead of HTTPS. Fixes: spacedentist#241
191b71c to
cbc50f0
Compare
Author
Thanks for the suggestion, added another commit to have clippy enforce this. |
Author
|
ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that pushing works even when users have configured their global gitconfig to always use SSH for pushing: using the entry
url.git@github.com:.pushinsteadof=https://github.com/See #241