Skip to content

git2: allow pushing via ssh#244

Open
arichardson wants to merge 3 commits intospacedentist:masterfrom
arichardson:ssh-feature
Open

git2: allow pushing via ssh#244
arichardson wants to merge 3 commits intospacedentist:masterfrom
arichardson:ssh-feature

Conversation

@arichardson
Copy link
Copy Markdown

This ensures that pushing works even when users have configured their global gitconfig to always use SSH for pushing: using the entry url.git@github.com:.pushinsteadof=https://github.com/

See #241

@arichardson arichardson changed the title git2: require https and ssh features git2: allow pushing via ssh Sep 22, 2025
@arichardson
Copy link
Copy Markdown
Author

ping? Does this look sensible?

This ensures that pushing works even when users have configured their
global gitconfig to always use SSH for pushing: using the entry
`url.git@github.com:.pushinsteadof=https://github.com/`
Copy link
Copy Markdown
Owner

@spacedentist spacedentist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this - if you can just do the one change in the comments.

Comment thread src/git_remote.rs Outdated
@arichardson
Copy link
Copy Markdown
Author

Happy to merge this - if you can just do the one change in the comments.

Thanks for the suggestion, added another commit to have clippy enforce this.

@arichardson
Copy link
Copy Markdown
Author

ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants