Skip to content

Default SFF8472 xcvr cable type to Unknown#606

Merged
prgeor merged 1 commit intosonic-net:masterfrom
lotus-nexthop:lotus.default-sfp-len
Mar 24, 2026
Merged

Default SFF8472 xcvr cable type to Unknown#606
prgeor merged 1 commit intosonic-net:masterfrom
lotus-nexthop:lotus.default-sfp-len

Conversation

@lotus-nexthop
Copy link
Copy Markdown
Contributor

@lotus-nexthop lotus-nexthop commented Oct 28, 2025 •
edited
Loading

Follow the pattern from sff8436.py and default to "Unknown" to prevent
None being returned.

Fixes sonic-net/sonic-buildimage#24369

Description

If the transceiver does not have one of the expected length-types, it
will be returned as None, which will cause an exception in xcvrd's
post_port_sfp_info_to_db() when it tries to marshal that data into a
swsscommon.FieldValuePairs because None is not a string.

Motivation and Context

We were seeing a continuous crash loop on NH-4010 when loopback
transceivers were installed.

How Has This Been Tested?

Verified it stopped the continuous crash loop on NH-4010 when the
appropriate loopbacks are installed.

Additional Information (Optional)

Crash logs

2025 May 22 22:11:28.544366 sonic ERR pmon#xcvrd[26]: Exception occured at SfpStateUpdateTask thread due to TypeError("Wrong number or type of arguments for overloaded function 'new_FieldValuePairs'.\n  Possible C/C++ prototypes are:\n    std::vector< std::pair< std::string,std::string > >::vector()\n    std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > > const &)\n    std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > >::size_type)\n    std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > >::size_type,std::vector< std::pair< std::string,std::string > >::value_type const &)\n")
2025 May 22 22:11:28.545424 sonic ERR pmon#xcvrd[26]: Traceback (most recent call last):
2025 May 22 22:11:28.545453 sonic ERR pmon#xcvrd[26]:   File "/usr/local/lib/python3.11/dist-packages/xcvrd/xcvrd.py", line 1907, in run
2025 May 22 22:11:28.545453 sonic ERR pmon#xcvrd[26]:     self.task_worker(self.task_stopping_event, self.sfp_error_event)
2025 May 22 22:11:28.545500 sonic ERR pmon#xcvrd[26]:   File "/usr/local/lib/python3.11/dist-packages/xcvrd/xcvrd.py", line 1715, in task_worker
2025 May 22 22:11:28.545500 sonic ERR pmon#xcvrd[26]:     self.init()
2025 May 22 22:11:28.545543 sonic ERR pmon#xcvrd[26]:   File "/usr/local/lib/python3.11/dist-packages/xcvrd/xcvrd.py", line 1633, in init
2025 May 22 22:11:28.545543 sonic ERR pmon#xcvrd[26]:     self.retry_eeprom_set = self._post_port_sfp_info_and_dom_thr_to_db_once(port_mapping_data, self.xcvr_table_helper, self.main_thread_stop_event)
2025 May 22 22:11:28.545563 sonic ERR pmon#xcvrd[26]:                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025 May 22 22:11:28.545616 sonic ERR pmon#xcvrd[26]:   File "/usr/local/lib/python3.11/dist-packages/xcvrd/xcvrd.py", line 1588, in _post_port_sfp_info_and_dom_thr_to_db_once
2025 May 22 22:11:28.545616 sonic ERR pmon#xcvrd[26]:     rc = post_port_sfp_info_to_db(logical_port_name, port_mapping, xcvr_table_helper.get_intf_tbl(asic_index), transceiver_dict, stop_event)
2025 May 22 22:11:28.545633 sonic ERR pmon#xcvrd[26]:          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025 May 22 22:11:28.545646 sonic ERR pmon#xcvrd[26]:   File "/usr/local/lib/python3.11/dist-packages/xcvrd/xcvrd.py", line 480, in post_port_sfp_info_to_db
2025 May 22 22:11:28.545646 sonic ERR pmon#xcvrd[26]:     fvs = swsscommon.FieldValuePairs([
2025 May 22 22:11:28.545711 sonic ERR pmon#xcvrd[26]:           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025 May 22 22:11:28.545711 sonic ERR pmon#xcvrd[26]:   File "/usr/lib/python3/dist-packages/swsscommon/swsscommon.py", line 224, in __init__
2025 May 22 22:11:28.545726 sonic ERR pmon#xcvrd[26]:     _swsscommon.FieldValuePairs_swiginit(self, _swsscommon.new_FieldValuePairs(*args))
2025 May 22 22:11:28.545739 sonic ERR pmon#xcvrd[26]:                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2025 May 22 22:11:28.545739 sonic ERR pmon#xcvrd[26]: TypeError: Wrong number or type of arguments for overloaded function 'new_FieldValuePairs'.
2025 May 22 22:11:28.545773 sonic ERR pmon#xcvrd[26]:   Possible C/C++ prototypes are:
2025 May 22 22:11:28.545773 sonic ERR pmon#xcvrd[26]:     std::vector< std::pair< std::string,std::string > >::vector()
2025 May 22 22:11:28.545822 sonic ERR pmon#xcvrd[26]:     std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > > const &)
2025 May 22 22:11:28.545822 sonic ERR pmon#xcvrd[26]:     std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > >::size_type)
2025 May 22 22:11:28.545841 sonic ERR pmon#xcvrd[26]:     std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > >::size_type,std::vector< std::pair< std::string,std::string > >::value_type const &)
2025 May 22 22:11:28.545841 sonic ERR pmon#xcvrd[26]: 
2025 May 22 22:11:28.545871 sonic NOTICE pmon#xcvrd[26]: Stop daemon main loop
2025 May 22 22:11:28.545921 sonic ERR pmon#xcvrd[26]: Xcvrd: exception found at child thread SfpStateUpdateTask due to TypeError("Wrong number or type of arguments for overloaded function 'new_FieldValuePairs'.\n  Possible C/C++ prototypes are:\n    std::vector< std::pa
ir< std::string,std::string > >::vector()\n    std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > > const &)\n    std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,s
td::string > >::size_type)\n    std::vector< std::pair< std::string,std::string > >::vector(std::vector< std::pair< std::string,std::string > >::size_type,std::vector< std::pair< std::string,std::string > >::value_type const &)\n")
2025 May 22 22:11:28.545955 sonic ERR pmon#xcvrd[26]: Exiting main loop as child thread raised exception!

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Oct 28, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Oct 28, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@lotus-nexthop lotus-nexthop mentioned this pull request Oct 28, 2025
Closed
@rlhui
Copy link
Copy Markdown

rlhui commented Nov 26, 2025

@lotus-nexthop , removing this PR from chassis project, this is not t2 right? thanks.

@rlhui rlhui removed this from SONiC Chassis Nov 26, 2025
@prgeor
Copy link
Copy Markdown
Collaborator

prgeor commented Feb 10, 2026

@lotus-nexthop what is the call stack for xcvrd crash?

@lotus-nexthop
Copy link
Copy Markdown
Contributor Author

lotus-nexthop commented Feb 10, 2026

@lotus-nexthop what is the call stack for xcvrd crash?

Hi @prgeor I added the call stack to the PR description

@prgeor prgeor requested a review from Copilot March 24, 2026 22:48
Copilot AI reviewed Mar 24, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the SFF-8472 transceiver info behavior with other module APIs by defaulting cable_type to "Unknown" instead of None, preventing downstream failures when transceiver info is marshaled into DB field/value pairs (per sonic-buildimage#24369).

Changes:

  • Default Sff8472Api.get_transceiver_info() cable_type to "Unknown" when no supported/positive length type is detected.

Comment thread sonic_platform_base/sonic_xcvr/api/public/sff8472.py
len_types = ["Length SMF (km)", "Length SMF (100m)", "Length OM2 (10m)", "Length OM1(10m)", "Length OM4(10m)", "Length OM3(10m)"]
cable_len = 0
cable_type = None
cable_type = "Unknown"
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change prevents returning None for cable_type, but there’s no unit test asserting the new behavior. Consider adding/adjusting a test to verify get_transceiver_info() returns cable_type == "Unknown" (and a string type) when all SFF-8472 length fields are 0/unsupported, to guard against regressions that could reintroduce xcvrd DB-marshalling crashes.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Collaborator

@prgeor prgeor Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lotus-nexthop looks to be a valid comment that you can address in new PR?

@prgeor prgeor merged commit 75a60a9 into sonic-net:master Mar 24, 2026
9 checks passed
shreyansh-nexthop pushed a commit to nexthop-ai/sonic-platform-common that referenced this pull request Apr 10, 2026
@lotus-nexthop @shreyansh-nexthop
Default SFF8472 xcvr cable type to Unknown (sonic-net#606)
f9c0376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prgeor prgeor prgeor approved these changes

Copilot code review Copilot Copilot left review comments

+1 more reviewer

@bobby-nexthop bobby-nexthop bobby-nexthop approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: SFF8472 loopback modules cause xcvrd exception

6 participants

@lotus-nexthop @mssonicbld @rlhui @prgeor @bobby-nexthop