Parameterize gNMI CONFIG DB tests with different VRFs#20456
Open
spandan-nexthop wants to merge 1 commit intosonic-net:masterfrom
Open
Parameterize gNMI CONFIG DB tests with different VRFs#20456spandan-nexthop wants to merge 1 commit intosonic-net:masterfrom
spandan-nexthop wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
9 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 tasks
spandan-nexthop
requested review from
a team,
wangxin and
yxieca
as code owners
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
645f3ac to
be3a2b2
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@qiluo-msft @sneelam20 @anand-kumar-subramanian @seiferteric Adding sonic-gnmi maintainers for viz |
Signed-off-by: Spandan Chowdhury <spandan@nexthop.ai>
spandan-nexthop
force-pushed
the
spandan-nexthop.vrf-aware-gnmi
branch
from
be3a2b2 to
8eb37b5
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Parameterize gNMI CONFIG DB tests with different VRFs to ensure correct VRF binding of gNMI listener
Summary:
Fixes sonic-net/sonic-buildimage#23865
Depends on:
Type of change
Back port request
Approach
What is the motivation for this PR?
To test the changes in sonic-net/sonic-gnmi#503 and sonic-net/sonic-buildimage#23867
How did you do it?
Parameterized
test_gnmi_configdb.pywithdefault,mgmt_vrfand a custom VRF scenario.How did you verify/test it?
Manual verification of relevant changes are already done with the
sonic-buildimagechanges.The updated tests ran successfully in local setup.
Any platform specific information?
NA
Supported testbed topology if it's a new test case?
Any testbed works for the default and
mvrftest cases.Custom non-mgmt VRF testcase requires a
t0topology for now, but it is not a realistic case anyway since the gNMI request is shoved through a dataplane VRF.Documentation
NA
A picture of a cute animal (not mandatory but encouraged)