Implements the frontend logic for gNSI Certz#559
Merged
sneelam20 merged 2 commits intosonic-net:masterfrom Mar 2, 2026
Merged
Conversation
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
d695948 to
46a4968
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
rlucus
suggested changes
Jan 26, 2026
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
46a4968 to
989dd86
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
989dd86 to
f6d715e
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
f6d715e to
4031f09
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
4031f09 to
fd9f8f2
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
fd9f8f2 to
7a6491f
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
7a6491f to
4f8f68c
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
5d002ca to
d6ac70b
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
d6ac70b to
2929413
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
2929413 to
4a09a86
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
4a09a86 to
a9f8cdc
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
rlucus
approved these changes
Feb 27, 2026
Contributor
rlucus
left a comment
rlucus
left a comment
There was a problem hiding this comment.
Approved, pending that function being moved back.
Signed-off-by: Pattela JAYARAGINI <pattelaj@google.com>
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
a9f8cdc to
bfd7b4a
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
bfd7b4a to
d26cd64
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Pattela JAYARAGINI <pattelaj@google.com>
jayaragini-hcl
force-pushed
the
gnsi_certz_fe_pr1_2
branch
from
d26cd64 to
ee4beb9
Compare
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
sneelam20
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables support for managing the device certificates,Trust bundles,CRLs and handles the certificate management using Certz Rotate() RPC
HLD Link
Dependency Chain for Merge
Backend Base PR : sonic-net/sonic-mgmt-common#183 (Must be merged first)
Backend Incremental PR : sonic-net/sonic-mgmt-common#198
Frontend Base PR: #596 (Must be merged first)
Incremental PR: #578
Current PR : #559
gNSI Certz UT Results:
=== RUN TestGnsiCertzServer
=== RUN TestGnsiCertzServer/RotateCertificateDefaultSuccess
=== RUN TestGnsiCertzServer/RotateCRLDefaultSuccess
=== RUN TestGnsiCertzServer/RotateTrustBundleSuccess
=== RUN TestGnsiCertzServer/RotateEmptyRequest
=== RUN TestGnsiCertzServer/RotateCertificateMissingCert
=== RUN TestGnsiCertzServer/RotateCertificateMissingKey
=== RUN TestGnsiCertzServer/RotateCertificateMissingType
=== RUN TestGnsiCertzServer/RotateCertificateMissingEncoding
=== RUN TestGnsiCertzServer/RotateTrustBundleMissingCert
=== RUN TestGnsiCertzServer/RotateTrustBundleMissingType
=== RUN TestGnsiCertzServer/RotateTrustBundleMissingEncoding
=== RUN TestGnsiCertzServer/RotateCRLMissingCert
=== RUN TestGnsiCertzServer/RotateCRLMissingType
=== RUN TestGnsiCertzServer/RotateCRLMissingEncoding
=== RUN TestGnsiCertzServer/AddProfileUnimplemented
=== RUN TestGnsiCertzServer/DeleteProfileUnimplemented
=== RUN TestGnsiCertzServer/GetProfileListUnimplemented
=== RUN TestGnsiCertzServer/CanGenerateCSRAccept
=== RUN TestGnsiCertzServer/CanGenerateCSRReject
=== RUN TestGnsiCertzServer/GenerateCsrRSA
=== RUN TestGnsiCertzServer/GenerateCsrECDSA
=== RUN TestGnsiCertzServer/GenerateCsrAttest
=== RUN TestGnsiCertzServer/restoreSymlink
=== RUN TestGnsiCertzServer/rmFileIfNotPointedToBySymlink
=== RUN TestGnsiCertzServer/isSymlinkValid
=== RUN TestGnsiCertzServer/Rotate_DoUpload_CRLNotConfigured
=== RUN TestGnsiCertzServer/CreatesCRLDefaultDirectories
=== RUN TestGnsiCertzServer/CRL_MkdirFailureLogging
=== RUN TestGnsiCertzServer/Rotate_ConcurrentRPC_ReturnsAborted
=== RUN TestGnsiCertzServer/Rotate_UnexpectedEOF_TriggersRevert
=== RUN TestGnsiCertzServer/Rotate_InvalidRequest_TriggersProcessErr
=== RUN TestGnsiCertzServer/RevertProfile_Full_Coverage
=== RUN TestGnsiCertzServer/SaveEntities_AuthPolicy_BackupAndWriteSuccess
=== RUN TestGnsiCertzServer/SaveEntities_AuthPolicy_SaveFailAndRestoreFail
=== RUN TestGnsiCertzServer/Rotate_Concurrent_Call_Error
=== RUN TestGnsiCertzServer/Rotate_Stream_Recv_Error
=== RUN TestGnsiCertzServer/Rotate_Process_Request_Error
=== RUN TestGnsiCertzServer/Rotate_Finalize_Failure_Coverage
=== RUN TestGnsiCertzServer/ReadCertChain_Full_Coverage
=== RUN TestGnsiCertzServer/ReadCertChain_Full_Coverage/ParentLoopValidationFailure
--- PASS: TestGnsiCertzServer (1.71s)
--- PASS: TestGnsiCertzServer/RotateCertificateDefaultSuccess (0.02s)
--- PASS: TestGnsiCertzServer/RotateCRLDefaultSuccess (0.01s)
--- PASS: TestGnsiCertzServer/RotateTrustBundleSuccess (0.02s)
--- PASS: TestGnsiCertzServer/RotateEmptyRequest (0.01s)
--- PASS: TestGnsiCertzServer/RotateCertificateMissingCert (0.01s)
--- PASS: TestGnsiCertzServer/RotateCertificateMissingKey (0.01s)
--- PASS: TestGnsiCertzServer/RotateCertificateMissingType (0.01s)
--- PASS: TestGnsiCertzServer/RotateCertificateMissingEncoding (0.01s)
--- PASS: TestGnsiCertzServer/RotateTrustBundleMissingCert (0.01s)
--- PASS: TestGnsiCertzServer/RotateTrustBundleMissingType (0.01s)
--- PASS: TestGnsiCertzServer/RotateTrustBundleMissingEncoding (0.01s)
--- PASS: TestGnsiCertzServer/RotateCRLMissingCert (0.01s)
--- PASS: TestGnsiCertzServer/RotateCRLMissingType (0.01s)
--- PASS: TestGnsiCertzServer/RotateCRLMissingEncoding (0.01s)
--- PASS: TestGnsiCertzServer/AddProfileUnimplemented (0.01s)
--- PASS: TestGnsiCertzServer/DeleteProfileUnimplemented (0.01s)
--- PASS: TestGnsiCertzServer/GetProfileListUnimplemented (0.01s)
--- PASS: TestGnsiCertzServer/CanGenerateCSRAccept (0.01s)
--- PASS: TestGnsiCertzServer/CanGenerateCSRReject (0.02s)
--- PASS: TestGnsiCertzServer/GenerateCsrRSA (0.53s)
--- PASS: TestGnsiCertzServer/GenerateCsrECDSA (0.01s)
--- PASS: TestGnsiCertzServer/GenerateCsrAttest (0.01s)
--- PASS: TestGnsiCertzServer/restoreSymlink (0.00s)
--- PASS: TestGnsiCertzServer/rmFileIfNotPointedToBySymlink (0.00s)
--- PASS: TestGnsiCertzServer/isSymlinkValid (0.00s)
--- PASS: TestGnsiCertzServer/Rotate_DoUpload_CRLNotConfigured (0.01s)
--- PASS: TestGnsiCertzServer/CreatesCRLDefaultDirectories (0.01s)
--- PASS: TestGnsiCertzServer/CRL_MkdirFailureLogging (0.01s)
--- PASS: TestGnsiCertzServer/Rotate_ConcurrentRPC_ReturnsAborted (0.02s)
--- PASS: TestGnsiCertzServer/Rotate_UnexpectedEOF_TriggersRevert (0.01s)
--- PASS: TestGnsiCertzServer/Rotate_InvalidRequest_TriggersProcessErr (0.01s)
--- PASS: TestGnsiCertzServer/RevertProfile_Full_Coverage (0.01s)
--- PASS: TestGnsiCertzServer/SaveEntities_AuthPolicy_BackupAndWriteSuccess (0.01s)
--- PASS: TestGnsiCertzServer/SaveEntities_AuthPolicy_SaveFailAndRestoreFail (0.01s)
--- PASS: TestGnsiCertzServer/Rotate_Concurrent_Call_Error (0.01s)
--- PASS: TestGnsiCertzServer/Rotate_Stream_Recv_Error (0.02s)
--- PASS: TestGnsiCertzServer/Rotate_Process_Request_Error (0.01s)
--- PASS: TestGnsiCertzServer/Rotate_Finalize_Failure_Coverage (0.01s)
--- PASS: TestGnsiCertzServer/ReadCertChain_Full_Coverage (0.00s)