[action] [PR:56] Add list of trusted VNIs#58
Open
mssonicbld wants to merge 1 commit intosonic-net:202511from
Open
[action] [PR:56] Add list of trusted VNIs#58mssonicbld wants to merge 1 commit intosonic-net:202511from
mssonicbld wants to merge 1 commit intosonic-net:202511from
Conversation
The current proto definition only allows a single value or range for trusted VNIs. If we want to trust two different VNIs, then we must use a range that includes all VNIs between them, which presents a security risk. This will require changes across multiple repos in the following order: 1. Update the protobuf definition to allow for multiple ranges and values for trusted VNIs (this PR) 2. Update orchagent code to parse the new protobuf definition and create multiple trusted VNI entries 3. Update sonic-mgmt tests to use the new definition 4. Update the protobuf definition to remove/deprecate the old `trusted_vni` field to avoid confusion.
Author
|
Original PR: #56 |
Merged
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current proto definition only allows a single value or range for trusted VNIs. If we want to trust two different VNIs, then we must use a range that includes all VNIs between them, which presents a security risk. This will require changes across multiple repos in the following order:
trusted_vnifield to avoid confusion.