Move sonic-dash-api-proto to sonic-dash-api#45
Draft
yue-fred-gao wants to merge 3 commits intosonic-net:masterfrom
Draft
Move sonic-dash-api-proto to sonic-dash-api#45yue-fred-gao wants to merge 3 commits intosonic-net:masterfrom
yue-fred-gao wants to merge 3 commits intosonic-net:masterfrom
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
hi @yue-fred-gao - do we need a reviewer for this one, or is it stale? TY! |
Author
It is kind of stale. Qi doesn't agree with PR sonic-net/sonic-swss-common#1077. So we might have it keep it as is |
Thanks! Do you think we should close it, or keep it in Draft for some time? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
currently, sonic-dash-ha adds sonic-dash-api as submodule to compile protos into rust structs. At the same time, both are submodules in sonic-buildimage. This creates unnecessary dependency and complexity. The solution is moving sonic-dash-api-proto crate into sonic-dash-api. sonic-dash-ha adds sonic-dash-api-proto as a dependent crate. At build time, it pulls the crate through git and the latter compiles protos on demand. This is similar to swss-common crate to sonic-dash-ha.
what this PR does
Move sonic-dash-api-proto crate to sonic-dash-api repo.
Note: this PR depends on sonic-net/sonic-swss-common#1077