Add serverity and power control to leak detection HLD#2217
Open
fraserg-arista wants to merge 1 commit intosonic-net:masterfrom
Open
Add serverity and power control to leak detection HLD#2217fraserg-arista wants to merge 1 commit intosonic-net:masterfrom
fraserg-arista wants to merge 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: Fraser Gordon <fraserg@arista.com>
fraserg-arista
force-pushed
the
leak-severity-hld
branch
from
c34993a to
7497a98
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Author
|
@judyjoseph I've opened this for design discussion for adding severity to leak detection. |
fraserg-arista
commented
Feb 23, 2026
|  | ||
|
|
||
| ### 3.1 Leak severity | ||
| Depending on the placement of a leak sensor within the chassis, a given leak event will represent a "major" or "minor" |
Author
There was a problem hiding this comment.
As per the design here, these should be changed to "critical" and "minor".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Posting for design discussion.
Adds severity information and power control operations (for the liquid-cooled power domain) to the leak detection high-level design. The two domains are major and minor, representing leaks that require immediate and delayed shutdown, respectively.
The interface attempts to be generic enough to support different hardware implementation approaches, for both sensor technology and for whether power control is handled in hardware/firmware, software, or both.