Added HLD for Console Monitor Service#2178
Open
wiperi wants to merge 6 commits intosonic-net:masterfrom
Open
Conversation
Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
wiperi
force-pushed
the
cliffchen/submit/console-monitor-hld
branch
from
efe559d to
21ccf51
Compare
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
wiperi
added a commit
to wiperi/sonic-host-services
that referenced
this pull request
Jan 18, 2026
- This is the implementation of HLD doc: sonic-net/SONiC#2178 Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
- update duration foramt in cli example - update oper_state to Up / Unknown Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
wiperi
added a commit
to wiperi/sonic-buildimage
that referenced
this pull request
Jan 20, 2026
Why I did it This PR supports [HLD](sonic-net/SONiC#2178) To support controlled_device attribute in CONSOLE_SWITCH table to enable/disable the controlled device feature on SONiC console switch. Sample config: "CONSOLE_SWITCH": { "console_mgmt": { "enabled": "yes" }, "controlled_device": { "enabled": "yes" } } How I did it Update Yang model for sonic-console and add corresponding unit tests: - Added controlled_device container in CONSOLE_SWITCH - Added test cases for default value verification - Added test cases for valid configuration - Added test cases for invalid pattern detection How to verify it Verified by unit test. Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
8 tasks
lizhijianrd
reviewed
Jan 21, 2026
|
|
||
| #### 3.3.3 Oper State Determination | ||
|
|
||
|  |
Contributor
There was a problem hiding this comment.
This link is outdated, need to update.
And the folder name has a typo, a missing n in word Design.
lizhijianrd
reviewed
Jan 22, 2026
| * If not in frame: flush buffer as user data | ||
| * If in frame: frame is incomplete, discard buffer contents | ||
| * Exit in-frame state | ||
|
|
Contributor
There was a problem hiding this comment.
Could you provide a table to show the timeout for commonly used band-rate?
Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
4 tasks
Signed-off-by: cliffchen <t-cliffchen+github@microsoft.com>
Collaborator
|
/azp run |
|
No pipelines are associated with this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The console monitor service provides real-time automatic detection of link Oper state, enabling observability for serial connections and allowing users to monitor link health status instantly.