feat: randomize rendered collections on every page load#20
Open
almndbtr wants to merge 1 commit intosongcamp:mainfrom
Open
feat: randomize rendered collections on every page load#20almndbtr wants to merge 1 commit intosongcamp:mainfrom
almndbtr wants to merge 1 commit intosongcamp:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Author
|
Manually tested the preview with 3 page refreshes; no issues that I can spot from my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #19
Previously, the home page rendered each of the edition collections by the date they were created. This PR randomizes the rendered collection on every page load, powered by
lodash.shuffle(the one new dependency).I tested these changes in local development. I'd be happy to test these to a staging deploy before having this merged in.
cc: @0xTranqui for review 👓